Thanks for doing that merge, Stefan!

I reviewed the merge and have some comments/errors.
 * debian/kerneloops-applet.{pre,post}inst only apply to an upgrade to 
pre-lucid. They could have been dropped since maverick, and should go away 
entirely now.
 * debian/kerneloops.default seems to be a dead file, duplicating 
debian/kerneloops-daemon.kerneloops.default. It should be dropped.
 * debian/patches/ubuntu-l10n_fi.patch should be dropped. This package is in 
main, and thus covered by langpacks.
 * debian/patches/ubuntu-modify-applet.patch should be dropped. Regardless of 
what it is doing (the merge summary changelog does not mention it), applets do 
not work any more since Ubuntu 11.10.
 * Can you please add the names of the patches to the changelog? It would also 
be nice to add patch headers to the patches (http://dep.debian.net/deps/dep3/), 
but not mandatory. They mainly help for patch maintenance, and you can be less 
verbose in the changelog instead.

Is that package still actually recommended upstream? The submit site has
been down for quite a while, and that package uses really old technology
(GTK 2, applets, etc.) It seems rather costly to keep large patches like
submit-pipe and kerneloops-submit downstream.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1006299

Title:
  Please merge kerneloops 0.12+git20090217-3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/kerneloops/+bug/1006299/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to