I can confirm we need a special check for 0 I just tested your patch and it is working. I can't reproduce bug mentioned in #22 (on Samsung N220), but it doesn't do anything bad, so I think it should be used.
But there must be a bug in code, because if I load the module the screen brightness changes. I couldn't see why set_brightness(initial_level); isn't really working. I just got an idea for the general quirk problem. Wouldn't it be the easiest to switch first to level 0 and than to the desired level ? (I'm no expert on this and I didn't tried it but I think this should always work (if switching is fast enough)) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/810093 Title: The new (2.6.39+) samsung_laptop kernel module causes serious backlight flickering - makes the desktop unusable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/810093/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
