I just had a quick look at the patch: 1) why you moved the break from before case STATE_MENU_ICON to after that line? mistake? 2) while I agree we don't want to write g_assert for all shadow and padding lines, I don't like the fact we are skipping also other fallback options. I suggest to not use STATE_FALLBACK but a different (new) state like UBUNTU_STATE_FALLBACK, where we can skip the gasserts
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/800315 Title: light-themes don't fully support Gnome Shell To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-design/+bug/800315/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
