Comment on attachment 546015 Patch v3.1 Review of attachment 546015: -----------------------------------------------------------------
r+ with that fixed ::: layout/generic/nsFrame.cpp @@ +2663,5 @@ > + > + // We should set minimum scroll speed same as the on-edge scrolling speed. > + // E.g., while mouse cursor is on the edge, scrolling speed is always same. > + // However, when the user moves 1px outside of the selection root element, > + // the scrolling speed is slow down. We should avoid this strange > behavior. Remove the last two lines of this comment, since they're confusing; it sounds like you're describing something that actually happens with this patch applied. @@ +2666,5 @@ > + // However, when the user moves 1px outside of the selection root element, > + // the scrolling speed is slow down. We should avoid this strange > behavior. > + nsPoint currentScrollPos = scrollableFrame->GetScrollPosition(); > + nsRect visibleRectOfScrolledFrame = scrollableFrame->GetScrollPortRect(); > + visibleRectOfScrolledFrame.MoveTo(currentScrollPos); This should be scrollableFrame->GetScrollPortRect() + curentScrollPos, right? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/744580 Title: Firefox doesn't auto scroll when selecting content downwards To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/744580/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
