Hi Chris! Thanks for your comment and for reviewing this SRU. Just to be clear, in Natty we already use the network_state_is_connected signal to disable *all* of the the software install buttons in the main UI, that is, for both the list and details views. All this patch does is make the corresponding menu item sensitivity consistent with the buttons themselves. It's not so much a cosmetic issue as it is a consistency in the UI issue.
I'm not aware of ever having a report of a false negative (or positive) for network_state_is_connected. And as I mentioned, if we were to get a false negative then all of the install buttons in the UI would become disabled. The user would have to then find the (inconsistently) still- enabled "Install" menu item to be able to attempt an install. I'm not sure it makes sense to leave this bug unfixed in order to cover that possibility. Regarding bug 802920, it is truly a bug to offer to "Install Previous Purchases" when a network connection is not available. The operation will simply fail silently in that case. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/802919 Title: Install menu is enabled while disconnected To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/software-center/+bug/802919/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
