Launchpad has imported 18 comments from the remote bug at https://bugzilla.mozilla.org/show_bug.cgi?id=440908.
If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. ------------------------------------------------------------------------ On 2008-06-21T00:56:40+00:00 Mh+mozilla wrote: Created attachment 326060 patch The attached patch allows to use lockPref() in any .js preference file (prefs.js, files in default/preferences...) Reply at: https://bugs.launchpad.net/thunderbird/+bug/623844/comments/0 ------------------------------------------------------------------------ On 2008-06-21T01:06:06+00:00 Mh+mozilla wrote: Created attachment 326061 patch Obviously, neither the debian changelog nor the fprintf should be in the patch. The first patch doesn't exist. You haven't seen it. The only patch existing is this one. Reply at: https://bugs.launchpad.net/thunderbird/+bug/623844/comments/1 ------------------------------------------------------------------------ On 2008-07-22T15:46:31+00:00 Benjamin Smedberg (Mozilla) [:bs] wrote: Because I apparently inherited ownership of this code by default, I'm going to need some more summary here: * what is the motivation for this change? * where did lockPref use to work? In what new cases are we making it work? * I'm going to need tests. I think writing an xpcshell test for this shouldn't be too hard. Reply at: https://bugs.launchpad.net/thunderbird/+bug/623844/comments/2 ------------------------------------------------------------------------ On 2008-07-22T15:48:23+00:00 Benjamin Smedberg (Mozilla) [:bs] wrote: Comment on attachment 326061 patch canceling review request until questions are answered Reply at: https://bugs.launchpad.net/thunderbird/+bug/623844/comments/3 ------------------------------------------------------------------------ On 2008-07-22T18:10:02+00:00 Mh+mozilla wrote: (In reply to comment #2) > Because I apparently inherited ownership of this code by default, I'm going to > need some more summary here: > > * what is the motivation for this change? > * where did lockPref use to work? In what new cases are we making it work? lockPref is an exclusive feature of the autoconfig stuff right now. Autoconfig uses a single file, located in the application directory, and which name is given by the general.config.filename preference, with pseudo security featured by a general.config.obscure_value preference. Autoconfig also allows to use javascript constructs, contrary to standard pref files that are limited to pref() and user_pref(). The problem we had in debian is that we need to lock some preferences, to avoid users to harm themselves with bad preferences. app.update.enable, for instance. The first solution was to use the general.config.filename/obscure_value pair to just do that. The problem is that this file being provided by the package, it is also overwritten on any package upgrade, which means admins needing to use autoconfig just can't. I found it a convenient way to solve this by allowing standard preferences to lock preferences. I'm pretty sure you can find some other uses to this feature. > * I'm going to need tests. I think writing an xpcshell test for this shouldn't > be too hard. Can you still review the patch without the tests ? Reply at: https://bugs.launchpad.net/thunderbird/+bug/623844/comments/4 ------------------------------------------------------------------------ On 2008-11-07T19:15:40+00:00 Benjamin Smedberg (Mozilla) [:bs] wrote: Frankly, to solve the specific case of Debian users trying to enable updates, I think the best course of action is to get rid of the app.update.url pref from the Debian builds: then even if the user were to turn updates on, nothing bad could happen. I'm trying to find somebody to help walk through the twisted jungle here; this is not likely to make it for FF3.1 because it touches something close to PAC, which is some of our most fragile code. Reply at: https://bugs.launchpad.net/thunderbird/+bug/623844/comments/5 ------------------------------------------------------------------------ On 2008-11-07T19:23:44+00:00 Mh+mozilla wrote: This has nothing to do with app.update.url, but with admins wanting to lock some prefs to their users without fidling with general.config.filename. Reply at: https://bugs.launchpad.net/thunderbird/+bug/623844/comments/6 ------------------------------------------------------------------------ On 2008-11-07T20:41:37+00:00 Benjamin Smedberg (Mozilla) [:bs] wrote: Which may be a worthwhile use case, but I'm pretty sure we don't want extensions to be able to lock preferences (for example), and it's not clear to me that we distinguish between admins and extensions very well. Reply at: https://bugs.launchpad.net/thunderbird/+bug/623844/comments/7 ------------------------------------------------------------------------ On 2008-11-07T21:14:15+00:00 Mh+mozilla wrote: Actually, AFAIK, an extension can already lock preferences... Reply at: https://bugs.launchpad.net/thunderbird/+bug/623844/comments/8 ------------------------------------------------------------------------ On 2008-11-11T19:58:31+00:00 Benjamin Smedberg (Mozilla) [:bs] wrote: Comment on attachment 326061 patch At least extensions should not be allowed to set locked prefs, so r-. I'm not sure what the right design is. Reply at: https://bugs.launchpad.net/thunderbird/+bug/623844/comments/9 ------------------------------------------------------------------------ On 2008-11-12T06:42:30+00:00 Mh+mozilla wrote: As I said, extensions can already lock preferences... Reply at: https://bugs.launchpad.net/thunderbird/+bug/623844/comments/10 ------------------------------------------------------------------------ On 2008-11-12T06:57:26+00:00 Reed Loden wrote: Comment on attachment 326061 patch Re-requesting review due to glandium's overlooked comment. Reply at: https://bugs.launchpad.net/thunderbird/+bug/623844/comments/11 ------------------------------------------------------------------------ On 2008-11-12T15:44:23+00:00 Benjamin Smedberg (Mozilla) [:bs] wrote: How can an extension lock preferences? Reply at: https://bugs.launchpad.net/thunderbird/+bug/623844/comments/12 ------------------------------------------------------------------------ On 2008-11-12T19:19:21+00:00 Mh+mozilla wrote: Created attachment 347810 extension locking a pref This is one way i was thinking of for an extension to lock a preference. There are, I guess, many others. Reply at: https://bugs.launchpad.net/thunderbird/+bug/623844/comments/13 ------------------------------------------------------------------------ On 2008-12-03T16:40:24+00:00 Benjamin Smedberg (Mozilla) [:bs] wrote: *** Bug 467738 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/thunderbird/+bug/623844/comments/14 ------------------------------------------------------------------------ On 2008-12-08T14:30:45+00:00 Benjamin Smedberg (Mozilla) [:bs] wrote: Comment on attachment 326061 patch ok, yes, extensions can do anything. I don't think we want them doing this, and this will be an attractive nuisance. Reply at: https://bugs.launchpad.net/thunderbird/+bug/623844/comments/15 ------------------------------------------------------------------------ On 2009-11-03T10:16:14+00:00 Mh+mozilla wrote: The point is, extensions already can lock prefs, so why not allow this patch, which doesn't change that, and file another bug to prevent extensions from locking prefs ? Reply at: https://bugs.launchpad.net/thunderbird/+bug/623844/comments/16 ------------------------------------------------------------------------ On 2010-03-30T06:31:36+00:00 Mh+mozilla wrote: Comment on attachment 326061 patch Re-requesting review per comment #16 Reply at: https://bugs.launchpad.net/thunderbird/+bug/623844/comments/17 ** Changed in: thunderbird Status: Unknown => In Progress ** Changed in: thunderbird Importance: Unknown => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/623844 Title: lockpref not honored in /etc/thunderbird/pref/thunderbird.js To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
