2011/4/21 Michal Soltys <sol...@ziu.info> > On 11-04-21 10:34, Arnaud Quette wrote: > >> Hi Lupe, >> >> since we now have an apcsmart maintainer, I'm forwarding this issue to >> him. >> >> @Michal: could you please have a look at this issue [1], and give us >> your feeling? >> >> cheers, >> Arnaud >> > > -- >> [1] https://bugs.launchpad.net/bugs/535583 >> >> 2011/2/15 Lupe Christoph <l...@lupe-christoph.de >> <mailto:l...@lupe-christoph.de>> >> >> > The suggestions are pretty fine. > > - flushing stale input (though at driver level) > > Certainly. I even added some flushes earlier, but haven't touched the > updateinfo and/or the functions it calls yet. I'll add it along with > forthcoming patches (icanon mode and the rest). Looking at the strace, > flushing post-failure might be good idea in certain cases as well. > > - reopening serial port > > If the upper layers of nut don't disallow this kind of behaviour for some > reason - it's good idea as well. Should be helpful in weird cases, and at > the very least wouldn't hurt at all. If it would help in this particular > case, hard to say. >
none special. we already have to somehow do so with USB devices. > - smartmode() > > TBH, I'm not sure why it diligently tries to enter SM 5 times. Pre-emptive > flush + 'Y' + reasonable delay (icanon or not) should be all that is > necessary. If we don't succeed, next attempt shouldn't miraculously (in > theory) make much of a difference 1 second later ... > > > Thanks for pointing out those issues. > thanks for taking care of it ;-) cheers, Arnaud -- Linux / Unix Expert R&D - Eaton - http://powerquality.eaton.com Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/ Debian Developer - http://www.debian.org Free Software Developer - http://arnaud.quette.free.fr/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/535583 Title: Excessive logging by apcsmart program -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
