>From the upstream announcement of the patch: The attached fixes two packet reordering bugs: 1) The check for out-of-order sequence numbers only validates that the sequence received is > the previous sequence received. But this is invalid if for instance packet 20 is received after packet 10. It should instead verify packet received == previous packet + 1. 2) The packet dequeue function was using the wrong pointer, which led to corruption of all packets placed on the queue when they were dequeued.
The attached patch is the code change for upstream version 1.34. Upstream felt this an important enough issue to make a release just for this patch. Here is the diff in their CVS: http://poptop.cvs.sourceforge.net/poptop/poptop/pptpgre.c?r1=1.8&r2=1.9&pathrev=HEAD Here is the patch submission: http://sourceforge.net/mailarchive/forum.php?thread_name=20070414033808.GA5212%40linuxace.com&forum_name =poptop-server ** Attachment added: "Patch to fix packer reordering issues" http://librarian.launchpad.net/7341673/pptpd-packet-reorder.patch ** Summary changed: - pptpd freeze + SRU proposal - pptpd freeze ** Description changed: Binary package hint: pptpd please there is a grave bug on reordering code in pptpd 1.3.0 1.3.1 1.3.3. Please update to 1.3.4. + + SRU proposal to implement the change from 1.3.4. ** Tags added: patch ** Tags removed: fixed upstream -- SRU proposal - pptpd freeze https://bugs.launchpad.net/bugs/107350 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
