> Matthew McGowan wrote:
> Yes i can add more alpha to the prelight.
> 
 Yeah. if we just increase alpha and make the pre-light subtle , this should be 
good.

> From memory the pressed state was style.mid[gtk.STATE_SELECTED], so
> whatever the gtk theme offers up.  Suggestions on a pressed state
> colour are welcome.
 Nah, the current one looks fine , was just wondering about for the color 
values used for those.

> I have a branch here with some tweaks lp:~mmcg069/software-center
/hover-highlight-tweaks

I was testing the branch with various themes , and hardcoding the colors doesnt 
work with all the themes. 
If the theme is a dark one then the prelight becomes too bold again , and if we 
tweak for the dark theme , it becomes light for other themes.

I would suggest we leave the prelight color to theme settings so that it would 
be more consistent with most of the themes out in the wild.
The following seems to work fine and more subtle in almost every theme i tested 
it in:
---------
        if self.state == gtk.STATE_PRELIGHT:
            r,g,b = floats_from_gdkcolor(self.style.mid[gtk.STATE_PRELIGHT])
        else:
            r,g,b = floats_from_gdkcolor(self.style.mid[gtk.STATE_SELECTED])
        cr.set_source_rgba(r,g,b, 0.15*self.alpha)
----------
What do you think .. ?


On a side note , i found a bug  unrelated to this one here. 
With Dark Room theme , the text is light before hover[when SC starts] and gets 
dark only after we hover over it... just mentioning, not sure if it was because 
i was testing latest SC on Lucid or if it was really a bug. :-)

-- 
Treat Categories on the homepage as buttons
https://bugs.launchpad.net/bugs/419787
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to