On Sat, 2009-03-21 at 11:49 +0000, TJ wrote: > On Sat, 2009-03-21 at 10:48 +0000, Scott James Remnant wrote: > > It isn't trivial, it's extraordinarily expensive - we run modprobe > > several hundred times during a normal boot, having to check the module > > options against the module would add a significant penalty! > > I've not been able to detect even a millisecond of difference using the > patched modprobe. > > The code only performs if options are being passed. If they are, the > already memory-mapped module image's .modinfo section is located and for > each "param=" the name is checked against the final list of options. If > the parameter occurs in the options it is kept. Any options not matched > are dropped. > I think this is dangerous - for example what if the option was to correct a security issue? Dropping the option would expose the hole again, you want the module load to fail and somebody to resolve the issue.
Scott -- Scott James Remnant sc...@canonical.com -- Wifi driver will fail to load if regulatory domain set in module options https://bugs.launchpad.net/bugs/343026 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
