Hi Andrew, thanks for the debdiff.

I've a question though...

This patch appears to be doing two things.  First, it's altering the
priority on some debug messages - this part I think is perfectly fine.

The other part is affecting the message printing logic:

+--- nfs-utils-1.1.2.orig/utils/gssd/err_util.c
++++ nfs-utils-1.1.2/utils/gssd/err_util.c
+@@ -49,6 +49,10 @@
+ {
+       va_list args;
+ 
++      /* Decrease verbosity so we don't log so much */
++      if ((priority - verbosity) > 1)
++              return;
++
+       /* Don't bother formatting a message we're never going to print! */
+       if (priority > verbosity)
+               return;

So this is changing the logic so it avoids printing messages unless the
'priority' is more than 'verbosity+1'.  This part I think should not be
included.  I think it's unnecessary anyway, and just doubles up on your
other fix.

Would you mind re-rolling the debdiff with this piece omitted?  (Or
explain why it's needed if I'm missing something.)

-- 
expired kerberos credentials cause significant syslog spam
https://bugs.launchpad.net/bugs/293705
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to