Re: [PATCH] efi_loader: avoid superfluous variable store writes on unchanged data

[Ilias Apalodimas]

Thanks Michal


The code looks sane apart from the runtime part.

[...]

> +
> +                       if (!memcmp(old_data, data1, size1)) {

So this will probably blowup in Linux. We had similar issues with
memcpy and added efi_memcpy_runtime()

> +                               *changep = false;
> +                               return EFI_SUCCESS;
> +                       }
> +               }
> +       }
> +
[...]\

Other than that LGTM

Thanks
/Ilias