On 2/24/26 10:23 AM, Macpaul Lin (林智斌) wrote:
Thank you, and yes, I was about to point out that this is a scsi core
code, this applies to SCSI, USB and such devices.
After re-visit the specification of SCSI SPC-4, we have confirmed the
standard inquiry (and the 1st) should not "less than" 36 bytes.
https://www.t10.org/members/w_spc4.htm
(A summary of SCSI-1 could be found here in html format
https://www.staff.uni-mainz.de/tacke/scsi/SCSI2-08.html#8.2.5 )
Compare the logic with the Linux's implementation in these sections:
https://elixir.bootlin.com/linux/v6.19.3/source/drivers/scsi/scsi_scan.c#L690
https://elixir.bootlin.com/linux/v6.19.3/source/drivers/scsi/scsi_scan.c#L801
https://elixir.bootlin.com/linux/v6.19.3/source/drivers/scsi/scsi_scan.c#L757
Unless the inquiry length has been assigned by the device, Linux use 36
bytes as the default standard inquiry length.
Is it possible to update the implementation in u-boot to use 36 bytes
as default standard inquiry lenght aligned with Linux, other devices
should apply vendor specific inquiry length with quirk settings. Would
it be okay? Looking forward for the further suggestions.
This would be OK, yes. Please update the commit message and send a V2.
Thank you for investigating this.
