Hello Tom, On Wed Sep 17, 2025 at 12:02 AM IST, Tom Rini wrote: > On Tue, Sep 16, 2025 at 04:28:51PM +0530, Anshul Dalal wrote: > >> Currently the logic to handle falcon mode as well as the regular boot is >> inside spl_mmc_do_fs_boot, this prevents us from cleanly extending >> falcon mode functionality like toggleable fallback to U-Boot proper. >> >> Therefore this patch splits the logic into spl_mmc_fs_load and >> spl_mmc_fs_load_os to handle the regular boot and falcon mode use case. >> >> Signed-off-by: Anshul Dalal <[email protected]> > [snip] >> + printf("%s, Failed to load falcon payload: %d\n", __func__, >> + ret); >> + printf("Fallback to U-Boot\n"); > > These are new. Do we really need to be adding them?
I think there should be some indication to the user that the intended boot mode (falcon in this case) has failed and they are relying on a fallback. Perhaps we can switch to a debug instead of printf here? Regards, Anshul
