Am 09.08.25 um 03:04 schrieb Mikhail Kshevetskiy: > From: Gabor Juhos <[email protected]> > > Since commit 3d1f08b032dc ("mtd: spinand: Use the external ECC engine > logic") the spinand_write_page() function ignores the errors returned > by spinand_wait(). Change the code to propagate those up to the stack > as it was done before the offending change. > > Cc: [email protected] > Fixes: 3d1f08b032dc ("mtd: spinand: Use the external ECC engine logic")
Not sure, but I think you should drop the "Cc: [email protected]" and "Fixes" tag here, as this is probably only relevant to the kernel, but not U-Boot. > Signed-off-by: Gabor Juhos <[email protected]> > Signed-off-by: Miquel Raynal <[email protected]> You should add your SoB tag here as you are the one porting the change to the U-Boot tree. > --- > drivers/mtd/nand/spi/core.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c > index daf6efb87d8..3e21a06dd0f 100644 > --- a/drivers/mtd/nand/spi/core.c > +++ b/drivers/mtd/nand/spi/core.c > @@ -691,7 +691,10 @@ int spinand_write_page(struct spinand_device *spinand, > SPINAND_WRITE_INITIAL_DELAY_US, > SPINAND_WRITE_POLL_DELAY_US, > &status); > - if (!ret && (status & STATUS_PROG_FAILED)) > + if (ret) > + return ret; > + > + if (status & STATUS_PROG_FAILED) > return -EIO; > > return spinand_ondie_ecc_finish_io_req(nand, (struct nand_page_io_req > *)req);
