Kindly ping. Best Regards, Alice Guo
> -----邮件原件----- > 发件人: U-Boot <[email protected]> 代表 Alice Guo (OSS) > 发送时间: 2025年7月8日 4:21 > 收件人: [email protected]; [email protected]; [email protected]; > [email protected]; Alice Guo <[email protected]>; > [email protected]; [email protected]; Peng Fan > <[email protected]>; Ye Li <[email protected]>; [email protected] > 抄送: [email protected] > 主题: [PATCH v2] clk: scmi: Fix clock identifier passed to struct > scmi_clk_parent_set_in > > From: Alice Guo <[email protected]> > > Commit aa7bdc1af505 ("clk: scmi: manage properly the clk identifier with > CFF") enables CONFIG_CLK_AUTO_ID, so need to use clk_get_id() to get the real > SCMI CLK ID, otherwise wrong ID is used when set clk parent. > > Fixes: aa7bdc1af505 ("clk: scmi: manage properly the clk identifier with > CCF") > > Signed-off-by: Alice Guo <[email protected]> > Reviewed-by: Peng Fan <[email protected]> > --- > > Changes for v2: > - improve commit log > - add Reviewed-by > > drivers/clk/clk_scmi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/clk_scmi.c b/drivers/clk/clk_scmi.c index > cfb372e6190..0c9a81cabcc 100644 > --- a/drivers/clk/clk_scmi.c > +++ b/drivers/clk/clk_scmi.c > @@ -336,8 +336,8 @@ static int scmi_clk_probe(struct udevice *dev) static > int __scmi_clk_set_parent(struct clk *clk, struct clk *parent) { > struct scmi_clk_parent_set_in in = { > - .clock_id = clk->id, > - .parent_clk = parent->id, > + .clock_id = clk_get_id(clk), > + .parent_clk = clk_get_id(parent), > }; > struct scmi_clk_parent_set_out out; > struct scmi_msg msg = SCMI_MSG_IN(SCMI_PROTOCOL_ID_CLOCK, > -- > 2.43.0
