On Sun, Jul 20, 2025 at 02:57:34AM +0300, Mikhail Kshevetskiy wrote: > > On 19.07.2025 17:57, Tom Rini wrote: > > On Sat, Jul 19, 2025 at 03:57:13AM +0300, Mikhail Kshevetskiy wrote: > > > >> This adds reset controller support for airoha en7523/en7529/en7562 SoCs. > >> > >> Signed-off-by: Mikhail Kshevetskiy <[email protected]> > >> --- > >> drivers/reset/reset-airoha.c | 63 +++++++++++++++++-- > >> .../dt-bindings/reset/airoha,en7523-reset.h | 61 ++++++++++++++++++ > >> 2 files changed, 119 insertions(+), 5 deletions(-) > >> create mode 100644 > >> dts/upstream/include/dt-bindings/reset/airoha,en7523-reset.h > > This is not the correct form of cherry-picking an upstream binding. > > What version of the kernel includes the required binding, to start with? > > Thanks. > This comes not from linux. I write it from the scratch.
Then it does not belong in "dts/upstream" and you need to also be submitting this upstream. We can temporarily take things that're being added upstream and not yet there, but if there's changes in the bindings we aren't going to maintain backwards compatibility either, so it's best to start upstream first. -- Tom
signature.asc
Description: PGP signature
