Hi, > -----Original Message----- > From: Heiko Schocher <[email protected]> > Sent: Saturday, 12 July 2025 4:14 pm > To: Maniyam, Dinesh <[email protected]>; [email protected] > Cc: Marek <[email protected]>; Simon <[email protected]>; > Simon Glass <[email protected]>; Tom Rini <[email protected]>; Dario > Binacchi <[email protected]>; Ilias Apalodimas > <[email protected]>; Heinrich Schuchardt <[email protected]>; > Jerome Forissier <[email protected]>; Mattijs Korpershoek > <[email protected]>; Ibai Erkiaga <[email protected]>; > Michal Simek <[email protected]>; Dmitry Rokosov > <[email protected]>; Jonas Karlman <[email protected]>; Sebastian > Reichel <[email protected]>; Tingting Meng > <[email protected]>; Chee, Tien Fong <[email protected]>; > Hea, Kok Kiang <[email protected]>; Ng, Boon Khai > <[email protected]>; Yuslaimi, Alif Zakuan > <[email protected]>; Hazim > <[email protected]>; Lim, Jit Loon > <[email protected]> > Subject: Re: [PATCH v5 03/12] drivers: i3c: Add i3c uclass driver. > > [CAUTION: This email is from outside your organization. Unless you trust the > sender, do not click on links or open attachments as it may be a fraudulent > email > attempting to steal your information and/or compromise your computer.] > > Hello Dinesh, > > On 13.05.25 12:19, [email protected] wrote: > > From: Dinesh Maniyam <[email protected]> > > > > Enable i3c general uclass driver. This uclass driver will have genaral > > read and write api to call the specific i3c driver. > > > > Signed-off-by: Dinesh Maniyam <[email protected]> > > --- > > doc/api/i3c.rst | 8 +++++ > > doc/api/index.rst | 1 + > > drivers/i3c/i3c-uclass.c | 38 +++++++++++++++++++++++ > > include/dw-i3c.h | 1 + > > include/i3c.h | 67 ++++++++++++++++++++++++++++++++++++++++ > > 5 files changed, 115 insertions(+) > > create mode 100644 doc/api/i3c.rst > > create mode 100644 drivers/i3c/i3c-uclass.c > > create mode 100644 include/i3c.h > > Patch drops error in CI: > > https://dev.azure.com/hs0298/hs/_build/results?buildId=179&view=logs&j=8a06 > d10a-f6aa-5571-1476-f02da1a95f96&t=90bc975e-aa28-5566-cec3- > 344578c5a53d&l=146 > > > ./include/i3c.h:54: warning: Function parameter or member 'read' not described > in 'dm_i3c_ops' > ./include/i3c.h:54: warning: Function parameter or member 'write' not > described > in 'dm_i3c_ops' > > Please fix this, beside of this, I tend to pic kup the series, just one > nitpick on > another patch. > > bye, > Heiko >
Sure, let me fix this. Regards Dinesh > -- > DENX Software Engineering GmbH, Managing Director: Johanna Denk, Tabea Lutz > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]
