On 7/8/25 18:51, Andrew Goodbody wrote:
> In tcp_parse_options the uchar p[0] is attempted to test for a match
> with the 32bit macro TCP_0_NOP which can never be true. Instead test
> against the 8bit macro TCP_1_NOP.
>
> This issue found by Smatch.
>
> Signed-off-by: Andrew Goodbody <[email protected]>
> ---
> net/tcp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/tcp.c b/net/tcp.c
> index 2635727f47d..8740150365f 100644
> --- a/net/tcp.c
> +++ b/net/tcp.c
> @@ -804,7 +804,7 @@ void tcp_parse_options(struct tcp_stream *tcp, uchar *o,
> int o_len)
> }
>
> /* Process optional NOPs */
> - if (p[0] == TCP_O_NOP)
> + if (p[0] == TCP_1_NOP)
> p++;
> else
> p += p[1];
>
Reviewed-by: Jerome Forissier <[email protected]>
Thanks,
--
Jerome
