On Fri, Jun 20, 2025 at 1:54 PM Tom Rini <[email protected]> wrote: > > On Fri, Jun 20, 2025 at 01:36:09PM -0500, Sam Protsenko wrote: > > On Fri, Jun 20, 2025 at 9:21 AM Tom Rini <[email protected]> wrote: > > > > > > On Thu, Jun 19, 2025 at 09:25:54PM -0500, Sam Protsenko wrote: > > > > > > > Avoid using MMC in board_init() to make sure disk objects are created in > > > > EFI subsystem later. > > > > > > > > If it's still possible, please take this series for 2025.07, as it makes > > > > EFI functional on E850-96 board. > > > > > > > > Sam Protsenko (2): > > > > configs: e850-96: Enable BOARD_LATE_INIT > > > > board: samsung: e850-96: Load LDFW in board_late_init() > > > > > > > > board/samsung/e850-96/e850-96.c | 9 +++++++++ > > > > configs/e850-96_defconfig | 1 + > > > > 2 files changed, 10 insertions(+) > > > > > > These should be one patch and also I think you want to disable > > > CONFIG_BOARD_INIT ? > > > > > > > Thanks for the review! I'll send v2 in an hour. But I wasn't able to > > find CONFIG_BOARD_INIT option: > > > > $ find . -name Kconfig* -exec grep -Hn "\bBOARD_INIT" {} \; > > > > initcall_run_r() seems to always call board_init() for ARM and other > > architectures: > > > > #if CONFIG_IS_ENABLED(ARM) || CONFIG_IS_ENABLED(RISCV) || \ > > CONFIG_IS_ENABLED(SANDBOX) > > INITCALL(board_init); /* Setup chipselects */ > > #endif > > > > Interesting thought though. I did a brief analysis, and it looks like > > there are 79 boards which have empty board_init() because it's not > > possible to disable it at the moment: > > > > $ grep -Pzrl "\bboard_init\(void\)\n{\n.*return 0;\n}\n" board/ | wc -l > > 79 > > > > Do you think U-Boot could benefit from having such an option? > > Yes, it looks like we need to clean the code up to match what we have in > Kconfig now, thanks! >
On it. Would appreciate it if you can take v2 as is for v2025.07, it fixes EFI on E850-96. > -- > Tom
