Hi Tom, On Wed, 18 Jun 2025 at 18:04, Tom Rini <[email protected]> wrote: > > On Wed, Jun 18, 2025 at 03:53:15PM -0400, Raymond Mao wrote: > > Hi Tom, > > > > On Wed, 18 Jun 2025 at 13:37, Tom Rini <[email protected]> wrote: > > > > > > On Wed, Jun 18, 2025 at 07:59:23AM -0700, Raymond Mao wrote: > > > > > > > Add blob type for DT overlay according to the update of Firmware > > > > Handoff spec[1]. > > > > > > > > [1] https://github.com/FirmwareHandoff/firmware_handoff/pull/74 > > > > > > > > Signed-off-by: Raymond Mao <[email protected]> > > > > > > Once merged, this should be a Link: line for tooling to better pick it > > > up. And I don't want to merge this here until it is merged / agreed to > > > in FirmwareHandoff. > > > > > > > diff --git a/include/bloblist.h b/include/bloblist.h > > > > index f32faf78560..b40e04fe2d3 100644 > > > > --- a/include/bloblist.h > > > > +++ b/include/bloblist.h > > > > @@ -110,7 +110,8 @@ enum bloblist_tag_t { > > > > BLOBLISTT_ACPI_TABLES = 4, > > > > BLOBLISTT_TPM_EVLOG = 5, > > > > BLOBLISTT_TPM_CRB_BASE = 6, > > > > - BLOBLISTT_ACPI_PP = 7, > > > > + BLOBLISTT_FDT_OVERLAY = 7, > > > > + BLOBLISTT_ACPI_PP = 8, > > > > > > ... sigh, so BLOBLISTT_ACPI_PP isn't something in FirmwareHandoff yet. > > > Was someone working on that it should it be moved down to the project > > > internal numbering area? > > Since we decided to make bloblist compliant to Firmware Handoff, it is > > required to get an ID placeholder in the spec first (at least a PR) > > before updating the code to avoid conflicts, but BLOBLISTT_ACPI_PP > > does not exist in the spec. In this case, I will consider it as a test > > only ID and can be shifted. Or I can move it into the custom range if > > you think that is better. > > I'm hoping maybe Patrick will chime in at least as yes, we should either > upstream it, or move it. I think shifting it to 8 makes sense, that is an un-occupied ID and is not blocking for submitting PR with.
Regards, Raymond > > -- > Tom
