On 6/17/25 12:03, Jerome Forissier wrote:
Prepare to split the dns command from cmd/net-lwip.c by moving the
implementation from net/lwip/dns.c to cmd/lwip.
Signed-off-by: Jerome Forissier <[email protected]>
---
Changes in v3:
- Move this patch before "lwip: split cmd/net-lwip.c into one file per
command".
Changes in v2:
- New patch
MAINTAINERS | 1 +
cmd/Makefile | 2 +-
cmd/lwip/Makefile | 1 +
{net => cmd}/lwip/dns.c | 0
net/lwip/Makefile | 1 -
5 files changed, 3 insertions(+), 2 deletions(-)
create mode 100644 cmd/lwip/Makefile
rename {net => cmd}/lwip/dns.c (100%)
diff --git a/MAINTAINERS b/MAINTAINERS
index d62dd35a385..e8f644fc75b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1409,6 +1409,7 @@ F: net/
NETWORK (LWIP)
M: Jerome Forissier <[email protected]>
S: Maintained
+F: cmd/lwip/
F: cmd/net-lwip.c
F: configs/qemu_arm64_lwip_defconfig
F: drivers/net/sandbox-lwip.c
diff --git a/cmd/Makefile b/cmd/Makefile
index 80cf70b7fe8..102422470c2 100644
--- a/cmd/Makefile
+++ b/cmd/Makefile
@@ -133,7 +133,7 @@ obj-$(CONFIG_CMD_NAND) += nand.o
ifdef CONFIG_NET
obj-$(CONFIG_CMD_NET) += net.o net-common.o
else ifdef CONFIG_NET_LWIP
-obj-$(CONFIG_CMD_NET) += net-lwip.o net-common.o
+obj-$(CONFIG_CMD_NET) += net-lwip.o net-common.o lwip/
Why should any command implemented in /cmd/lwip/ depend on CONFIG_CMD_NET?
Directory lwip/ should always be traversed if CONFIG_NET_LWIP=y.
We should get rid of CONFIG_CMD_NET once all commands are well separated.
Best regards
Heinrich
endif
obj-$(CONFIG_ENV_SUPPORT) += nvedit.o
obj-$(CONFIG_CMD_NVEDIT_EFI) += nvedit_efi.o
diff --git a/cmd/lwip/Makefile b/cmd/lwip/Makefile
new file mode 100644
index 00000000000..6c4ab58d06b
--- /dev/null
+++ b/cmd/lwip/Makefile
@@ -0,0 +1 @@
+obj-$(CONFIG_CMD_DNS) += dns.o
diff --git a/net/lwip/dns.c b/cmd/lwip/dns.c
similarity index 100%
rename from net/lwip/dns.c
rename to cmd/lwip/dns.c
diff --git a/net/lwip/Makefile b/net/lwip/Makefile
index 5df222589b8..255c7d018b0 100644
--- a/net/lwip/Makefile
+++ b/net/lwip/Makefile
@@ -2,7 +2,6 @@ ccflags-y += -I$(srctree)/lib/lwip/lwip/src/include
-I$(srctree)/lib/lwip/u-boot
obj-$(CONFIG_$(PHASE_)DM_ETH) += net-lwip.o
obj-$(CONFIG_CMD_DHCP) += dhcp.o
-obj-$(CONFIG_CMD_DNS) += dns.o
obj-$(CONFIG_CMD_PING) += ping.o
obj-$(CONFIG_CMD_TFTPBOOT) += tftp.o
obj-$(CONFIG_WGET) += wget.o
