On Sat, May 24, 2025 at 05:23:48AM +0100, Simon Glass wrote: > Hi Tom, > > On Fri, 23 May 2025 at 22:25, Tom Rini <[email protected]> wrote: > > > > On Fri, May 23, 2025 at 09:20:37PM +0100, Simon Glass wrote: > > > Hi Tom, > > > > > > On Fri, 23 May 2025 at 17:47, Tom Rini <[email protected]> wrote: > > > > > > > > On Fri, May 23, 2025 at 05:32:36PM +0100, Simon Glass wrote: > > > > > Hi Tom, > > > > > > > > > > On Fri, 23 May 2025 at 15:04, Tom Rini <[email protected]> wrote: > > > > > > > > > > > > On Fri, May 23, 2025 at 08:19:30AM -0500, Simon Glass wrote: > > > > > > > It is easier for tests if the top-level control logic is all in > > > > > > > one > > > > > > > module. Create a new do_patman() function to handle this. Move the > > > > > > > existing code into it. > > > > > > > > > > > > > > Signed-off-by: Simon Glass <[email protected]> > > > > > > > --- > > > > > > > > > > > > > > (no changes since v1) > > > > > > > > > > > > > > tools/patman/__main__.py | 49 > > > > > > > ++---------------------------------- > > > > > > > tools/patman/control.py | 54 > > > > > > > ++++++++++++++++++++++++++++++++++++++-- > > > > > > > 2 files changed, 54 insertions(+), 49 deletions(-) > > > > > > > > > > > > > > Applied to sjg/master, thanks! > > > > > > > > > > > > Odd. I thought you had posted this against master or next, > > > > > > intending it > > > > > > for mainline, which is why I assigned it to you in patchwork. I see > > > > > > the > > > > > > cover letter is missing what commit it's against. And instead here > > > > > > you > > > > > > are once again spamming the list and with messages about your > > > > > > personal > > > > > > tree. Why? > > > > > > > > > > I'm applying it to my tree and intend to send you a PR at some point, > > > > > with collected tools/ patches. So I believe I need to send emails > > > > > about applying things and update it in patchwork. Let's discuss this > > > > > in a future call. > > > > > > > > I don't see what there is to discuss. Please follow the normal process > > > > for mainline and stop spamming the list with notices for your personal > > > > tree. You're also diverging your own tree further from mainline by doing > > > > this and making it less likely (multiple people have told you they don't > > > > want to review things not against mainline) any follow-up work will get > > > > comments other than that it's not applicable to mainline. > > > > > > For patman, I have another series [1] I'm planning to apply to my tree > > > tomorrow > > > > > > Would you like me to send 'applied' emails for it to the mailing list? > > > Or perhaps just for the cover letter? Would you like me to send you a > > > pull request? > > > > > > Regards, > > > Simon > > > > > > [1] https://patchwork.ozlabs.org/project/uboot/list/?series=456256 > > > > Yes, that's another series that while I disagree with the direction > > you're taking things, would rather apply to mainline than let it bitrot > > in mainline. So please send a PR against next. And that would also apply > > to the series this email is in reply to. As again, I had expected it for > > mainline and not your downstream tree even if I think we (and our users) > > would all benefit from managing the python portions differently. > > OK, once I have applied the remaining two series I will send a PR.
Based on the emails in my inbox this morning, you're doing the opposite of what I asked for. But maybe this afternoon will bring something different. > You didn't express a preference for the 'applied' emails. It seems > better to send these emails so that there is a record of the patch > being applied. I guess I wasn't clear enough. Stop spamming the list with *anything* about your personal tree. And if you're going to send anything about something that's intended for mainline, you should make patman act more like b4 and NOT send a message to every patch. I know I used to, but the workflow b4 enables is much better for everyone. -- Tom
signature.asc
Description: PGP signature
