As far as I can tell no one makes any use of test/py/tests/test_memtest.py. At least there is no entry in u-boot-hooks that will enable its use.

This is not surprising as the code does not actually work correctly. It will construct a command line for the 'mtest' command with some decimal parameters and some in hex. 'mtest' will interpret all parameters as hex and this makes the test fail for almost anything apart from the trivial cases where the affected parameters are 0.

I looked into this for a while before I found the documentation that describes memory testing which states that 'mtest' is deprecated.

So my question is should I submit a patch to fix the test even though the command itself is deprecated? Should I then enable its use in CI? Alternatively should I submit a patch to remove the test as it is not used and is broken?

If the test should be removed a follow up question would be should the command itself be removed as well? This will be harder to do as it seems that some boards are using the config default values in their board code.

Andrew

Reply via email to