Re: [PATCH v2 1/6] dts: ipq9574-rdp433-u-boot: add override dtsi

[Caleb Connolly]

Hi Varadarajan,

Sorry for the not getting to this sooner!
On 1/30/25 05:37, Varadarajan Narayanan wrote:
Add initial support for the IPQ9574 MMC based RDP platforms.
Define memory layout statically.

Signed-off-by: Varadarajan Narayanan <quic_var...@quicinc.com>
---
v2: Use upstream and override DT instead of own DT
---
  arch/arm/dts/ipq9574-rdp433-u-boot.dtsi | 19 +++++++++++++++++++
  1 file changed, 19 insertions(+)
  create mode 100644 arch/arm/dts/ipq9574-rdp433-u-boot.dtsi

diff --git a/arch/arm/dts/ipq9574-rdp433-u-boot.dtsi 
b/arch/arm/dts/ipq9574-rdp433-u-boot.dtsi
new file mode 100644
index 0000000000..71832d350b
--- /dev/null
+++ b/arch/arm/dts/ipq9574-rdp433-u-boot.dtsi
@@ -0,0 +1,19 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2025, Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/ {
+       /* Will be removed when bootloader updates later */

Could you elaborate a little here? Are you referring to when SMEM 
parsing is supported in U-Boot? Or some change in a prior boot stage?
+       memory@40000000 {
+               device_type = "memory";
+               reg = <0x0 0x40000000 0x0 0x40000000>,
+                     <0x0 0x4a500000 0x0 0x00100000>;
+       };
+};
+
+&sdhc_1 {
+       sdhci-caps-mask = <0x0 0x04000000>;
+       sdhci-caps = <0x0 0x04000000>;
Please annotate this

+       resets = <&gcc GCC_SDCC_BCR>;

A comment here explaining why this isn't in the upstream DT would also 
be good.

Kind regards,
+};

--
Caleb (they/them)