On Wed, Feb 05, 2025 at 11:01:03AM +0800, Michael Chang wrote: > Add a new event which handles this function refer commit > id 91caa3bb89b112a1421ee2ee3661baf67c64bab9.
Please rephrase this as:
... refer to commit ("91caa3bb89b1 event: Use an event to replace
last_stage_init()")
I'd do that when applying, but:
> Signed-off-by: Michael Chang <[email protected]>
> ---
> board/nuvoton/arbel_evb/arbel_evb.c | 5 ++++-
> board/nuvoton/poleg_evb/poleg_evb.c | 5 ++++-
> configs/arbel_evb_defconfig | 1 -
> configs/poleg_evb_defconfig | 1 +
> 4 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/board/nuvoton/arbel_evb/arbel_evb.c
> b/board/nuvoton/arbel_evb/arbel_evb.c
> index 55e93a77f0..b5194f713a 100644
> --- a/board/nuvoton/arbel_evb/arbel_evb.c
> +++ b/board/nuvoton/arbel_evb/arbel_evb.c
> @@ -4,6 +4,7 @@
> */
>
> #include <dm.h>
> +#include <event.h>
> #include <asm/io.h>
> #include <asm/arch/gcr.h>
> #include "../common/uart.h"
> @@ -98,9 +99,11 @@ int dram_init_banksize(void)
> return 0;
> }
>
> -int last_stage_init(void)
> +static int last_stage_init(void)
> {
> board_set_console();
>
> return 0;
> }
> +EVENT_SPY_SIMPLE(EVT_LAST_STAGE_INIT, last_stage_init);
Please make board_set_console return in and don't wrap last_stage_init
here. Doing so only makes sense when like on the other platform there's
more going on in the function.
--
Tom
signature.asc
Description: PGP signature
