> -----Original Message-----
> From: Ng, Boon Khai <[email protected]>
> Sent: Friday, January 17, 2025 2:56 PM
> To: Uboot Open List <[email protected]>
> Cc: Chee, Tien Fong <[email protected]>; Hea, Kok Kiang
> <[email protected]>; Maniyam, Dinesh
> <[email protected]>; Yuslaimi, Alif Zakuan
> <[email protected]>; Zamri, Muhammad Hazim Izzat
> <[email protected]>; Tien Fong Chee
> <[email protected]>; Kok Kiang Hea <[email protected]>;
> Dinesh Maniyam <[email protected]>; Alif Zakuan
> <[email protected]>; Boon Khai Ng
> <[email protected]>; Muhammad Hazim
> <[email protected]>; Joe Hershberger
> <[email protected]>; Ramon Fried <[email protected]>; Tom Rini
> <[email protected]>; Simon Glass <[email protected]>; Ng, Boon Khai
> <[email protected]>
> Subject: [XGMAC RGMII-ID fix v1 1/1] net: dwc_eth_xgmac_socfpga: Add
> support for rgmii-id mode.
> 
> An issue was identified where selecting the phy-mode as rgmii-id in the
> device tree source (DTS) would cause the `dwc_eth_xgmac_socfpga` driver
> to raise an unsupported phy mode error.
> 
> From the MAC controller's perspective, the rgmii and rgmii-id phy modes are
> effectively identical. To address this, both modes will now be configured to
> rgmii in the MAC controller.
> 
> This change ensures that the rgmii-id phy mode is properly supported
> without error.
> 
> Signed-off-by: Boon Khai Ng <[email protected]>
> ---
>  drivers/net/dwc_eth_xgmac_socfpga.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/dwc_eth_xgmac_socfpga.c
> b/drivers/net/dwc_eth_xgmac_socfpga.c
> index 87fb7e887e..1864187c17 100644
> --- a/drivers/net/dwc_eth_xgmac_socfpga.c
> +++ b/drivers/net/dwc_eth_xgmac_socfpga.c
> @@ -80,6 +80,7 @@ static int xgmac_probe_resources_socfpga(struct
> udevice *dev)
>               modereg = SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_RMII;
>               break;
>       case PHY_INTERFACE_MODE_RGMII:
> +     case PHY_INTERFACE_MODE_RGMII_ID:
>               modereg =
> SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_RGMII;
>               break;
>       default:
> --
> 2.26.2

Reviewed-by: Tien Fong Chee <[email protected]>

Best regards,
Tien Fong

Reply via email to