Hi Ilias, On Fri, 10 Jan 2025 at 08:32, Ilias Apalodimas <[email protected]> wrote:
> On Thu, 9 Jan 2025 at 17:09, Raymond Mao <[email protected]> wrote: > > > > Get tpm event log from bloblist instead of FDT when bloblist is > > enabled and valid from previous boot stage. > > > > As a fallback, when no event log from previous stage is observed > > and no user buffer is passed, malloc an 8KB buffer to initialize > > the event log. > > > > Signed-off-by: Raymond Mao <[email protected]> > > --- > > Changes in v2 > > - Remove patch dependency. > > - Remove the fallback to FDT when BLOBLIST is selected. > > Changes in v3 > > - Malloc an 8KB buffer when user eventlog buffer does not exist. > > > > include/tpm_tcg2.h | 2 ++ > > lib/tpm_tcg2.c | 55 ++++++++++++++++++++++++++++++---------------- > > 2 files changed, 38 insertions(+), 19 deletions(-) > > > > diff --git a/include/tpm_tcg2.h b/include/tpm_tcg2.h > > index 6519004cc4..6ea316888b 100644 > > --- a/include/tpm_tcg2.h > > +++ b/include/tpm_tcg2.h > > @@ -65,6 +65,8 @@ > > #define EFI_DTB_EVENT_STRING \ > > "DTB DATA" > > > > +#define EVENT_LOG_DEF_BUF_SIZE 0x2000 > > That's too small for an eventlog. We have a confog option for the TCG > eventlog size (EFI_TCG2_PROTOCOL_EVENTLOG_SIZE). I'd prefer decoupling > this from EFI only and using that instead. > > I got this size from "reg" of "memory-region", but yes I agree with what you suggested. [snip] Regards, Raymond
