> -----Original Message-----
> From: Patrice Chotard <[email protected]>
> Sent: Tuesday, December 3, 2024 7:06 PM
> To: [email protected]
> Cc: Patrice CHOTARD <[email protected]>; Patrick DELAUNAY
> <[email protected]>; U-
> Boot STM32 <[email protected]>; Jaehoon Chung
> <[email protected]>; Jonas
> Karlman <[email protected]>; Marek Vasut <[email protected]>; Quentin Schulz
> <[email protected]>;
> Simon Glass <[email protected]>; Tom Rini <[email protected]>
> Subject: [PATCH v2 1/2] power: regulator: replace some debug() by dev_dbg()
>
> Replace some debug() by dev_dbg() when dev variable
> is available/valid.
>
> Signed-off-by: Patrice Chotard <[email protected]>
Reviewed-by: Jaehoon Chung <[email protected]>
Best Regards,
Jaehoon Chung
>
> ---
>
> Changes in v2:
> - rework dev_dbg() message to avoid printing twice dev->name.
>
> drivers/power/regulator/regulator-uclass.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/power/regulator/regulator-uclass.c
> b/drivers/power/regulator/regulator-uclass.c
> index decd0802c84..80ea5e65d48 100644
> --- a/drivers/power/regulator/regulator-uclass.c
> +++ b/drivers/power/regulator/regulator-uclass.c
> @@ -9,6 +9,7 @@
> #include <errno.h>
> #include <dm.h>
> #include <log.h>
> +#include <dm/device_compat.h>
> #include <dm/uclass-internal.h>
> #include <linux/delay.h>
> #include <power/pmic.h>
> @@ -43,8 +44,7 @@ static void regulator_set_value_ramp_delay(struct udevice
> *dev, int old_uV,
> {
> int delay = DIV_ROUND_UP(abs(new_uV - old_uV), ramp_delay);
>
> - debug("regulator %s: delay %u us (%d uV -> %d uV)\n", dev->name, delay,
> - old_uV, new_uV);
> + dev_dbg(dev, "delay %u us (%d uV -> %d uV)\n", delay, old_uV, new_uV);
>
> udelay(delay);
> }
> @@ -263,7 +263,7 @@ int regulator_get_by_platname(const char *plat_name,
> struct udevice **devp)
> for (ret = uclass_find_first_device(UCLASS_REGULATOR, &dev); dev;
> ret = uclass_find_next_device(&dev)) {
> if (ret) {
> - debug("regulator %s, ret=%d\n", dev->name, ret);
> + dev_dbg(dev, "ret=%d\n", ret);
> continue;
> }
>
> @@ -439,16 +439,15 @@ static int regulator_post_bind(struct udevice *dev)
> /* Regulator's mandatory constraint */
> uc_pdata->name = dev_read_string(dev, property);
> if (!uc_pdata->name) {
> - debug("%s: dev '%s' has no property '%s'\n",
> - __func__, dev->name, property);
> + dev_dbg(dev, "has no property '%s'\n", property);
> uc_pdata->name = dev_read_name(dev);
> if (!uc_pdata->name)
> return -EINVAL;
> }
>
> if (!regulator_name_is_unique(dev, uc_pdata->name)) {
> - debug("'%s' of dev: '%s', has nonunique value: '%s\n",
> - property, dev->name, uc_pdata->name);
> + dev_dbg(dev, "'%s' has nonunique value: '%s\n",
> + property, uc_pdata->name);
> return -EINVAL;
> }
>
> --
> 2.25.1
