On Fri, Nov 01, 2024 at 04:32:56PM +0100, Simon Glass wrote: > Hi Tom, > > On Thu, 31 Oct 2024 at 19:10, Tom Rini <[email protected]> wrote: > > > > On Thu, Oct 31, 2024 at 07:00:41PM +0100, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 29 Oct 2024 at 17:36, Tom Rini <[email protected]> wrote: > > > > > > > > On Tue, Oct 29, 2024 at 04:45:40PM +0100, Simon Glass wrote: > > > > > Hi Tom, > > > > > > > > > > On Mon, 28 Oct 2024 at 20:33, Tom Rini <[email protected]> wrote: > > > > > > > > > > > > On Mon, Oct 28, 2024 at 01:41:08PM +0100, Simon Glass wrote: > > > > > > > > > > > > > There is no particular need for bloblist to have its own test > > > > > > > suite. > > > > > > > Move it into the common suite instead. > > > > > > > > > > > > > > Add the missing help for 'common' and update the docs. > > > > > > > > > > > > > > Signed-off-by: Simon Glass <[email protected]> > > > > > > > > > > > > This feels both like churn and weird. I would think "common" tests > > > > > > are > > > > > > for things that are kinda legacy and too catch-all to have their own > > > > > > subgroup. > > > > > > > > > > It's just chosen so that the test for common/ is in test/common - i.e. > > > > > it makes it easier for people to find it. > > > > > > > > Then I really don't understand renaming bloblist from something > > > > descriptive to common which is not. > > > > > > Old: test/bloblist.c > > > New: test/common/bloblist.c > > > > > > It is only the directory that is changing. > > > > Then some of the commit messages need to be reworked? It looks like it > > stops being "ut bloblist" and part of "ut common" and that's my concern. > > Oh I see... > > I basically decided that there is no point in having a special suite > for bloblist, and some other things. A better way to handle this would > be to allow running tests which match a name, e.g. 'ut common > bloblist', because we are adding way too many suites IMO.
OK. It's not a big deal, yeah. I think the common use cases are "run everything" and "run this one test that failed while I debug it". -- Tom
signature.asc
Description: PGP signature
