Hi Patrick, On Wed, 18 Sept 2024 at 17:22, Patrick Rudolph <[email protected]> wrote: > > From: Maximilian Brune <[email protected]> > > Write the FADT in common code since it's used on all architectures. > Since the FADT is mandatory all SoCs or mainboards must implement the > introduced function acpi_fill_fadt() and properly update the FADT. > > Signed-off-by: Patrick Rudolph <[email protected]> > Cc: Simon Glass <[email protected]> > Cc: Bin Meng <[email protected]> > --- > Changelog v4: > - Drop __weak attribute > > --- > arch/sandbox/lib/acpi_table.c | 6 +++++ > arch/x86/cpu/apollolake/acpi.c | 20 ++++------------ > arch/x86/cpu/baytrail/acpi.c | 17 +------------- > arch/x86/cpu/quark/acpi.c | 19 +--------------- > arch/x86/cpu/tangier/acpi.c | 25 ++------------------ > arch/x86/include/asm/acpi_table.h | 12 ---------- > arch/x86/lib/acpi_table.c | 23 ------------------- > include/acpi/acpi_table.h | 9 ++++++++ > lib/acpi/acpi_table.c | 38 +++++++++++++++++++++++++++++++ > 9 files changed, 61 insertions(+), 108 deletions(-) > create mode 100644 arch/sandbox/lib/acpi_table.c >
Reviewed-by: Simon Glass <[email protected]> I was really expecting each file to have its own ACPI_WRITER() decl and then call into common code for the common part. But I suppose this way around is OK. Regards, Simon
