Re: [PATCH u-boot-marvell 1/3] arm: mvebu: turris_omnia: Rename variable holding EEPROM udevice

[Stefan Roese]

On 8/29/24 10:08, Marek Behún wrote:

Rename the variable holding the EEPROM udevice from `chip` to `eeprom`.

Signed-off-by: Marek Behún <ka...@kernel.org>
---
  board/CZ.NIC/turris_omnia/turris_omnia.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c 
b/board/CZ.NIC/turris_omnia/turris_omnia.c
index 2f29d26edf8..392df53a6d8 100644
--- a/board/CZ.NIC/turris_omnia/turris_omnia.c
+++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
@@ -464,16 +464,16 @@ static bool check_eeprom_crc(const void *buf, size_t 
size, u32 expected,

static bool omnia_read_eeprom(struct omnia_eeprom *oep)

  {
-       struct udevice *chip;
+       struct udevice *eeprom;
        int ret;

- chip = omnia_get_i2c_chip("EEPROM", OMNIA_I2C_EEPROM_CHIP_ADDR,

-                                 OMNIA_I2C_EEPROM_CHIP_LEN);
+       eeprom = omnia_get_i2c_chip("EEPROM", OMNIA_I2C_EEPROM_CHIP_ADDR,
+                                   OMNIA_I2C_EEPROM_CHIP_LEN);

- if (!chip)

+       if (!eeprom)
                return false;

- ret = dm_i2c_read(chip, 0, (void *)oep, sizeof(*oep));

+       ret = dm_i2c_read(eeprom, 0, (void *)oep, sizeof(*oep));
        if (ret) {
                printf("dm_i2c_read failed: %i, cannot read EEPROM\n", ret);
                return false;

Reviewed-by: Stefan Roese <s...@denx.de>

Thanks,
Stefan