On Wed, 28 Aug 2024 at 15:10, Jerome Forissier <[email protected]> wrote: > > The fec_mxc_init() function currently always returns 0. This does not > allow the callers to detect when for instance the PHY initialization > failed due to the port being unconnected. Fix that by returning the > status of fec_open(). > > Signed-off-by: Jerome Forissier <[email protected]> > Reviewed-by: Fabio Estevam <[email protected]> > --- > drivers/net/fec_mxc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c > index 0a0d92bc2c..2dc1364bee 100644 > --- a/drivers/net/fec_mxc.c > +++ b/drivers/net/fec_mxc.c > @@ -615,8 +615,7 @@ static int fecmxc_init(struct udevice *dev) > if (fec->xcv_type != SEVENWIRE) > miiphy_restart_aneg(dev); > #endif > - fec_open(dev); > - return 0; > + return fec_open(dev); > } > > /** > -- > 2.40.1 >
Reviewed-by: Ilias Apalodimas <[email protected]>
