On Fri, 2 Aug 2024 12:24:56 +0530 Sumit Garg <[email protected]> wrote:
Hi Sumit, > Hi Chris, > > On Fri, 2 Aug 2024 at 04:29, Chris Morgan <[email protected]> wrote: > > > > From: Chris Morgan <[email protected]> > > > > The Anbernic RG35XX series of devices are based around an Allwinner > > H700 SoC with 1GB of RAM, 2 SD cards, and multiple input buttons. > > > > This bootloader has been tested on the Anbernic RG35XX-2024 and > > RG35XX-H, but should be suitable for the entire lineup of H700 based > > devices. > > > > A future series of updates will add board selection logic to identify > > and load the correct device tree automatically, and will switch to > > utilizing a mainline device tree. > > I can already see the upstream DT subtree containing DTS for this board as: > > ./dts/upstream/src/arm64/allwinner/sun50i-h700-anbernic-rg35xx-2024.dts > > Are there any major differences that won't allow you to switch to > OF_UPSTREAM for this board? In this case there are no differences between the DT in the kernel repo and what we put in U-Boot. The main reason for me holding back the switch to OF_UPSTREAM for the H616 was indeed the rather slow update cadence, which somewhat slows down upstreaming of new boards like this. Doing this separately gives us a bit more control and freedom to take DT patches early, for instance when they appear in some Linux -rc1, or even before that (linux-next). I explained my position in more detail here: https://lore.kernel.org/u-boot/[email protected]/ I think Tom partly convinced me that regular updates together with cherry-picking should solve most of those problems, so I will probably do the switch for the next cycle. Cheers, Andre > > > > Signed-off-by: Chris Morgan <[email protected]> > > --- > > arch/arm/dts/Makefile | 3 +- > > .../dts/sun50i-h700-anbernic-rg35xx-2024.dts | 320 ++++++++++++++++++ > > board/sunxi/MAINTAINERS | 5 + > > configs/anbernic_rg35xx_h700_defconfig | 50 +++ > > 4 files changed, 377 insertions(+), 1 deletion(-) > > create mode 100644 arch/arm/dts/sun50i-h700-anbernic-rg35xx-2024.dts > > create mode 100644 configs/anbernic_rg35xx_h700_defconfig > > > > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile > > index 3ae4110d60..886ab0312a 100644 > > --- a/arch/arm/dts/Makefile > > +++ b/arch/arm/dts/Makefile > > @@ -679,10 +679,11 @@ dtb-$(CONFIG_MACH_SUN50I_H6) += \ > > sun50i-h6-tanix-tx6-mini.dtb > > dtb-$(CONFIG_MACH_SUN50I_H616) += \ > > sun50i-h616-orangepi-zero2.dtb \ > > + sun50i-h616-x96-mate.dtb \ > > sun50i-h618-orangepi-zero2w.dtb \ > > sun50i-h618-orangepi-zero3.dtb \ > > sun50i-h618-transpeed-8k618-t.dtb \ > > - sun50i-h616-x96-mate.dtb > > + sun50i-h700-anbernic-rg35xx-2024.dtb > > dtb-$(CONFIG_MACH_SUN50I) += \ > > sun50i-a64-amarula-relic.dtb \ > > sun50i-a64-bananapi-m64.dtb \ > > diff --git a/arch/arm/dts/sun50i-h700-anbernic-rg35xx-2024.dts > > b/arch/arm/dts/sun50i-h700-anbernic-rg35xx-2024.dts > > new file mode 100644 > > index 0000000000..75206af164 > > --- /dev/null > > +++ b/arch/arm/dts/sun50i-h700-anbernic-rg35xx-2024.dts > > @@ -0,0 +1,320 @@ > > +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +/* > > + * Copyright (C) 2024 Ryan Walklin <[email protected]>. > > + */ > > + > > +/dts-v1/; > > + > > +#include "sun50i-h616.dtsi" > > +#include <dt-bindings/gpio/gpio.h> > > +#include <dt-bindings/input/linux-event-codes.h> > > +#include <dt-bindings/interrupt-controller/arm-gic.h> > > +#include <dt-bindings/leds/common.h> > > + > > +/ { > > + model = "Anbernic RG35XX 2024"; > > + chassis-type = "handset"; > > + compatible = "anbernic,rg35xx-2024", "allwinner,sun50i-h700"; > > + > > + aliases { > > + serial0 = &uart0; > > + }; > > + > > + chosen { > > + stdout-path = "serial0:115200n8"; > > + }; > > + > > + gpio_keys_gamepad: gpio-keys-gamepad { > > + compatible = "gpio-keys"; > > + > > + button-a { > > + label = "Action-Pad A"; > > + gpios = <&pio 0 0 GPIO_ACTIVE_LOW>; /* PA0 */ > > + linux,input-type = <EV_KEY>; > > + linux,code = <BTN_EAST>; > > + }; > > + > > + button-b { > > + label = "Action-Pad B"; > > + gpios = <&pio 0 1 GPIO_ACTIVE_LOW>; /* PA1 */ > > + linux,input-type = <EV_KEY>; > > + linux,code = <BTN_SOUTH>; > > + }; > > + > > + button-down { > > + label = "D-Pad Down"; > > + gpios = <&pio 4 0 GPIO_ACTIVE_LOW>; /* PE0 */ > > + linux,input-type = <EV_KEY>; > > + linux,code = <BTN_DPAD_DOWN>; > > + }; > > + > > + button-l1 { > > + label = "Key L1"; > > + gpios = <&pio 0 10 GPIO_ACTIVE_LOW>; /* PA10 */ > > + linux,input-type = <EV_KEY>; > > + linux,code = <BTN_TL>; > > + }; > > + > > + button-l2 { > > + label = "Key L2"; > > + gpios = <&pio 0 11 GPIO_ACTIVE_LOW>; /* PA11 */ > > + linux,input-type = <EV_KEY>; > > + linux,code = <BTN_TL2>; > > + }; > > + > > + button-left { > > + label = "D-Pad left"; > > + gpios = <&pio 0 8 GPIO_ACTIVE_LOW>; /* PA8 */ > > + linux,input-type = <EV_KEY>; > > + linux,code = <BTN_DPAD_LEFT>; > > + }; > > + > > + button-menu { > > + label = "Key Menu"; > > + gpios = <&pio 4 3 GPIO_ACTIVE_LOW>; /* PE3 */ > > + linux,input-type = <EV_KEY>; > > + linux,code = <BTN_MODE>; > > + }; > > + > > + button-r1 { > > + label = "Key R1"; > > + gpios = <&pio 0 12 GPIO_ACTIVE_LOW>; /* PA12 */ > > + linux,input-type = <EV_KEY>; > > + linux,code = <BTN_TR>; > > + }; > > + > > + button-r2 { > > + label = "Key R2"; > > + gpios = <&pio 0 7 GPIO_ACTIVE_LOW>; /* PA7 */ > > + linux,input-type = <EV_KEY>; > > + linux,code = <BTN_TR2>; > > + }; > > + > > + button-right { > > + label = "D-Pad Right"; > > + gpios = <&pio 0 9 GPIO_ACTIVE_LOW>; /* PA9 */ > > + linux,input-type = <EV_KEY>; > > + linux,code = <BTN_DPAD_RIGHT>; > > + }; > > + > > + button-select { > > + label = "Key Select"; > > + gpios = <&pio 0 5 GPIO_ACTIVE_LOW>; /* PA5 */ > > + linux,input-type = <EV_KEY>; > > + linux,code = <BTN_SELECT>; > > + }; > > + button-start { > > + label = "Key Start"; > > + gpios = <&pio 0 4 GPIO_ACTIVE_LOW>; /* PA4 */ > > + linux,input-type = <EV_KEY>; > > + linux,code = <BTN_START>; > > + }; > > + > > + button-up { > > + label = "D-Pad Up"; > > + gpios = <&pio 0 6 GPIO_ACTIVE_LOW>; /* PA6 */ > > + linux,input-type = <EV_KEY>; > > + linux,code = <BTN_DPAD_UP>; > > + }; > > + > > + button-x { > > + label = "Action-Pad X"; > > + gpios = <&pio 0 3 GPIO_ACTIVE_LOW>; /* PA3 */ > > + linux,input-type = <EV_KEY>; > > + linux,code = <BTN_NORTH>; > > + }; > > + > > + button-y { > > + label = "Action Pad Y"; > > + gpios = <&pio 0 2 GPIO_ACTIVE_LOW>; /* PA2 */ > > + linux,input-type = <EV_KEY>; > > + linux,code = <BTN_WEST>; > > + }; > > + }; > > + > > + gpio-keys-volume { > > + compatible = "gpio-keys"; > > + autorepeat; > > + > > + button-vol-up { > > + label = "Key Volume Up"; > > + gpios = <&pio 4 1 GPIO_ACTIVE_LOW>; /* PE1 */ > > + linux,input-type = <EV_KEY>; > > + linux,code = <KEY_VOLUMEUP>; > > + }; > > + > > + button-vol-down { > > + label = "Key Volume Down"; > > + gpios = <&pio 4 2 GPIO_ACTIVE_LOW>; /* PE2 */ > > + linux,input-type = <EV_KEY>; > > + linux,code = <KEY_VOLUMEDOWN>; > > + }; > > + }; > > + > > + leds { > > + compatible = "gpio-leds"; > > + > > + led-0 { > > + function = LED_FUNCTION_POWER; > > + color = <LED_COLOR_ID_GREEN>; > > + gpios = <&pio 8 12 GPIO_ACTIVE_HIGH>; /* PI12 */ > > + default-state = "on"; > > + }; > > + }; > > + > > + reg_vcc5v: regulator-vcc5v { /* USB-C power input */ > > + compatible = "regulator-fixed"; > > + regulator-name = "vcc-5v"; > > + regulator-min-microvolt = <5000000>; > > + regulator-max-microvolt = <5000000>; > > + }; > > +}; > > + > > +&cpu0 { > > + cpu-supply = <®_dcdc1>; > > +}; > > + > > +&mmc0 { > > + vmmc-supply = <®_cldo3>; > > + disable-wp; > > + cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */ > > + bus-width = <4>; > > + status = "okay"; > > +}; > > + > > +&pio { > > + vcc-pa-supply = <®_cldo3>; > > + vcc-pc-supply = <®_cldo3>; > > + vcc-pe-supply = <®_cldo3>; > > + vcc-pf-supply = <®_cldo3>; > > + vcc-pg-supply = <®_aldo4>; > > + vcc-ph-supply = <®_cldo3>; > > + vcc-pi-supply = <®_cldo3>; > > +}; > > + > > +&r_i2c { > > + status = "okay"; > > + > > + axp717: pmic@34 { > > + compatible = "x-powers,axp717"; > > + reg = <0x34>; > > + interrupt-controller; > > + #interrupt-cells = <1>; > > + interrupt-parent = <&nmi_intc>; > > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > > + > > + vin1-supply = <®_vcc5v>; > > + vin2-supply = <®_vcc5v>; > > + vin3-supply = <®_vcc5v>; > > + vin4-supply = <®_vcc5v>; > > + > > + regulators { > > + reg_dcdc1: dcdc1 { > > + regulator-always-on; > > + regulator-min-microvolt = <900000>; > > + regulator-max-microvolt = <1160000>; > > + regulator-name = "vdd-cpu"; > > + }; > > + > > + reg_dcdc2: dcdc2 { > > + regulator-always-on; > > + regulator-min-microvolt = <940000>; > > + regulator-max-microvolt = <940000>; > > + regulator-name = "vdd-gpu-sys"; > > + }; > > + > > + reg_dcdc3: dcdc3 { > > + regulator-always-on; > > + regulator-min-microvolt = <1100000>; > > + regulator-max-microvolt = <1100000>; > > + regulator-name = "vdd-dram"; > > + }; > > + > > + reg_aldo1: aldo1 { > > + /* 1.8v - unused */ > > + }; > > + > > + reg_aldo2: aldo2 { > > + /* 1.8v - unused */ > > + }; > > + > > + reg_aldo3: aldo3 { > > + /* 1.8v - unused */ > > + }; > > + > > + reg_aldo4: aldo4 { > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-name = "vcc-pg"; > > + }; > > + > > + reg_bldo1: bldo1 { > > + /* 1.8v - unused */ > > + }; > > + > > + reg_bldo2: bldo2 { > > + regulator-always-on; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-name = "vcc-pll"; > > + }; > > + > > + reg_bldo3: bldo3 { > > + /* 2.8v - unused */ > > + }; > > + > > + reg_bldo4: bldo4 { > > + /* 1.2v - unused */ > > + }; > > + > > + reg_cldo1: cldo1 { > > + /* 3.3v - audio codec - not yet implemented > > */ > > + }; > > + > > + reg_cldo2: cldo2 { > > + /* 3.3v - unused */ > > + }; > > + > > + reg_cldo3: cldo3 { > > + regulator-always-on; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-name = "vcc-io"; > > + }; > > + > > + reg_cldo4: cldo4 { > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-name = "vcc-wifi"; > > + }; > > + > > + reg_boost: boost { > > + regulator-min-microvolt = <5000000>; > > + regulator-max-microvolt = <5200000>; > > + regulator-name = "boost"; > > + }; > > + > > + reg_cpusldo: cpusldo { > > + regulator-always-on; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1400000>; > > + regulator-name = "cpusldo"; > > + }; > > + }; > > + }; > > +}; > > + > > +&uart0 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&uart0_ph_pins>; > > + status = "okay"; > > +}; > > + > > +&usbotg { > > + dr_mode = "peripheral"; > > + status = "okay"; > > +}; > > + > > +&usbphy { > > + status = "okay"; > > +}; > > diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS > > index 4bcd9b9af7..e31c1b3a83 100644 > > --- a/board/sunxi/MAINTAINERS > > +++ b/board/sunxi/MAINTAINERS > > @@ -121,6 +121,11 @@ M: Paul Kocialkowski <[email protected]> > > S: Maintained > > F: configs/Ainol_AW1_defconfig > > > > +ANBERNIC RG35XX-2024 > > +M: Chris Morgan <[email protected]> > > +S: Maintained > > +F: configs/anbernic_rg35xx_h700_defconfig > > + > > AMARULA A64-RELIC > > M: Jagan Teki <[email protected]> > > S: Maintained > > diff --git a/configs/anbernic_rg35xx_h700_defconfig > > b/configs/anbernic_rg35xx_h700_defconfig > > new file mode 100644 > > index 0000000000..e8958aaf57 > > --- /dev/null > > +++ b/configs/anbernic_rg35xx_h700_defconfig > > @@ -0,0 +1,50 @@ > > +CONFIG_ARM=y > > +CONFIG_ARCH_SUNXI=y > > +CONFIG_DEFAULT_DEVICE_TREE="sun50i-h700-anbernic-rg35xx-2024" > > +CONFIG_SPL=y > > +CONFIG_DRAM_SUN50I_H616_DX_ODT=0x08080808 > > +CONFIG_DRAM_SUN50I_H616_DX_DRI=0x0e0e0e0e > > +CONFIG_DRAM_SUN50I_H616_CA_DRI=0x0e0e > > +CONFIG_DRAM_SUN50I_H616_ODT_EN=0x7887bbbb > > +CONFIG_DRAM_SUN50I_H616_TPR2=0x1 > > +CONFIG_DRAM_SUN50I_H616_TPR6=0x40808080 > > +CONFIG_DRAM_SUN50I_H616_TPR10=0x402f6633 > > +CONFIG_DRAM_SUN50I_H616_TPR11=0x1a1e1e1b > > +CONFIG_MACH_SUN50I_H616=y > > +CONFIG_RESERVE_ALLWINNER_BOOT0_HEADER=y > > +CONFIG_SUNXI_DRAM_H616_LPDDR4=y > > +CONFIG_DRAM_CLK=672 > > +CONFIG_R_I2C_ENABLE=y > > +CONFIG_DEFAULT_FDT_FILE="sun50i-h700-anbernic-rg35xx-2024.dtb" > > +CONFIG_LAST_STAGE_INIT=y > > +CONFIG_SPL_I2C=y > > +CONFIG_CMD_BDINFO_EXTRA=y > > +CONFIG_CMD_BOOTDEV=y > > +CONFIG_CMD_BOOTMETH=y > > +CONFIG_CMD_BOOTZ=y > > +CONFIG_BOOTM_OPENRTOS=y > > +CONFIG_BOOTM_OSE=y > > +CONFIG_CMD_ADTIMG=y > > +CONFIG_CMD_ADC=y > > +CONFIG_CMD_CLK=y > > +# CONFIG_CMD_LOADB is not set > > +# CONFIG_CMD_LOADS is not set > > +CONFIG_CMD_BKOPS_ENABLE=y > > +CONFIG_CMD_MMC_REG=y > > +CONFIG_CMD_MMC_SWRITE=y > > +CONFIG_CMD_SDRAM=y > > +CONFIG_CMD_PMIC=y > > +CONFIG_CMD_REGULATOR=y > > +# CONFIG_NET is not set > > +CONFIG_BUTTON=y > > +CONFIG_BUTTON_GPIO=y > > +CONFIG_SPL_SYS_I2C_LEGACY=y > > +CONFIG_SYS_I2C_MVTWSI=y > > +CONFIG_SYS_I2C_SLAVE=0x7f > > +CONFIG_SYS_I2C_SPEED=400000 > > +CONFIG_REGULATOR_AXP=y > > +CONFIG_AXP717_POWER=y > > +CONFIG_AXP_DCDC2_VOLT=940 > > +CONFIG_AXP_DCDC3_VOLT=1100 > > +CONFIG_REGEX=y > > +# CONFIG_EFI_LOADER is not set > > -- > > 2.34.1 > >
