On Thu, 6 Jun 2024 at 09:38, Michal Simek <[email protected]> wrote: > > > > On 6/5/24 17:09, Ilias Apalodimas wrote: > > On Wed, 5 Jun 2024 at 17:58, Michal Simek <[email protected]> wrote: > >> > >> It is useful when structure is also used for saving vendor data covered > >> by CRC32. > >> > >> Signed-off-by: Michal Simek <[email protected]> > >> --- > >> > >> cmd/fwu_mdata.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/cmd/fwu_mdata.c b/cmd/fwu_mdata.c > >> index 3c8be576ac7a..9c048d69a131 100644 > >> --- a/cmd/fwu_mdata.c > >> +++ b/cmd/fwu_mdata.c > >> @@ -22,6 +22,7 @@ static void print_mdata(struct fwu_data *data) > >> printf("\tFWU Metadata\n"); > >> printf("crc32: %#x\n", data->crc32); > >> printf("version: %#x\n", data->version); > >> + printf("size: %#x\n", data->metadata_size); > > > > That's only available in v2 > > IS_ENABLED(CONFIG_FWU_MDATA_V1) etc? > > This field should be present in v1 and v2 case because it is the part of > fwu_data (u-boot private structure) not fwu_mdata (which match the spec). > But I have sent v2 and only printing it in v2 case.
Ah you are right, I was looking at an older tree.... Reviewed-by: Ilias Apalodimas <[email protected]> > > Thanks, > Michal
