Hi Manorit

On 28/05/24 13:14, Manorit Chawdhry wrote:
Hi Neha,

On 13:07-20240528, Neha Malcom Francis wrote:
From: Apurva Nandan <[email protected]>

This virtual clock mux configuration enables the use of dynamic frequency
scaling on A72 clock ID 202 by setting up the required register.

Signed-off-by: Apurva Nandan <[email protected]>
Signed-off-by: Neha Malcom Francis <[email protected]>
---
Boot logs:
https://gist.github.com/nehamalcom/138d25fe32d4d80af3e0e4c19c1b18e0

  arch/arm/dts/k3-j721e-r5-common-proc-board.dts | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/dts/k3-j721e-r5-common-proc-board.dts 
b/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
index 9655ca21d02..25e4b4c7663 100644
--- a/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
+++ b/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
@@ -28,7 +28,8 @@
                                <&k3_pds 4 TI_SCI_PD_EXCLUSIVE>;
                resets = <&k3_reset 202 0>;
                clocks = <&k3_clks 61 1>;
-               assigned-clocks = <&k3_clks 202 2>, <&k3_clks 61 1>;
+               assigned-clocks = <&k3_clks 202 2>, <&k3_clks 61 1>, <&k3_clks 342 
0>;
+               assigned-clock-parents= <0>, <0>, <&k3_clks 342 2>;

I think it would be better to base this patch on top of your j721e
of_upstream series. There you have introduced k3-j721e-r5.dtsi [0] and I
feel it would be better to put this change on that file maybe.

[0]: https://lore.kernel.org/u-boot/[email protected]/


I'll line this up after OF_UPSTREAM is taken in or requires a next version whichever happens first. Thanks for the review!

Regards,
Manorit
                assigned-clock-rates = <2000000000>, <200000000>;
                ti,sci = <&dmsc>;
                ti,sci-proc-id = <32>;
--
2.34.1


--
Thanking You
Neha Malcom Francis

Reply via email to