On Thu, May 23, 2024 at 04:01:31PM +0000, Brunham, Kalen wrote:

> I can see that efi_device_path.c and efi_disk.c both #include blk.h. 

OK, yes. But what I'm asking of Heinrich is, can we easily and cleanly
make that support conditional? Or is there some underlying requirement
at play here?

> 
> -----Original Message-----
> From: Tom Rini <[email protected]> 
> Sent: Thursday, May 23, 2024 11:33 AM
> To: Brunham, Kalen <[email protected]>; Heinrich Schuchardt 
> <[email protected]>
> Cc: [email protected]
> Subject: Re: [PATCH 1/1] Added arm64 assembly for examples/api crt0
> 
> On Wed, May 22, 2024 at 05:22:24PM +0000, Brunham, Kalen wrote:
> 
> > Hi Tom,
> > 
> > BLK is currently a dependency for EFI_LOADER as shown in the snippet from 
> > lib/efi_loader/Kconfig below. Perhaps the question is why EFI_LOADER 
> > requires a block device? If I remove this depends on BLK line, then I can 
> > enable EFI and successfully simulate the EFI hello world on my test design. 
> > 
> > 
> > config EFI_LOADER
> >     bool "Support running UEFI applications"
> >     depends on OF_LIBFDT && ( \
> >             ARM && (SYS_CPU = arm1136 || \
> >                     SYS_CPU = arm1176 || \
> >                     SYS_CPU = armv7   || \
> >                     SYS_CPU = armv8)  || \
> >             X86 || RISCV || SANDBOX)
> >     # We need EFI_STUB_64BIT to be set on x86_64 with EFI_STUB
> >     depends on !EFI_STUB || !X86_64 || EFI_STUB_64BIT
> >     # We need EFI_STUB_32BIT to be set on x86_32 with EFI_STUB
> >     depends on !EFI_STUB || !X86 || X86_64 || EFI_STUB_32BIT
> >     depends on BLK
> >     depends on !EFI_APP
> >     default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
> 
> Do you recall why this is Heinrich?
> 
> -- 
> Tom

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to