With 0.99.48:

1. Turn on source code, save and refresh sources, close app
2. Start again, observe the flag is on.
^ works so far
3. Turn "recommended updates" to "all updates", observe that -backports got 
added with deb-src, to the existing paragraph.
^ here backports got added with deb only
4. Restart the app and observe that the flag is still on.
^ surprisingly this was on rather than half-way checked, which may be a 
difference in theme or something.


With 0.99.49.1:

The behavior is _almost_ correct, it all technically works correctly,
except in the lxd vm it adds an extra paragraph for backports, rather
than merging with the one for noble noble-updates.

There's no point holding up the SRU to fix that though, I have created
bug 2084568 to track the follow up work.

** Tags removed: verification-needed verification-needed-noble
** Tags added: verification-done verification-done-noble

** Description changed:

  [Impact]
  If you have Source Code enabled, and you change the pockets configuration to 
"all pockets", it will add -backports without source code. The Source Code flag 
will still be set in the UI, but after a reload, you can see it is in a mixed 
state.
  
  This is more notable now, because this splits up the deb822 paragraph
  into two: One for the deb, and one for deb-src, whereas it should remain
  one.
  
  [Test plan]
  1. Turn on source code, save and refresh sources, close app
  2. Start again, observe the flag is on.
- 3. Turn "recommended updates" to "all updates", observe that -backports got 
added with deb-src, to the existing paragraph.
+ 3. Turn "recommended updates" to "all updates", observe that -backports got 
added with deb-src (formerly this said: to the existing paragraph, this is now 
tracked in bug 2084568)
  4. Restart the app and observe that the flag is still on.
  
  [Where problems could occur]
  This incurs a performance regression, as we need to check the state of the 
source code flag after reloading sources. That said, this is of course 
necessary for the source code flag to be correct after reloading modified 
sources (it gets reset to False when reloading). And since we run in a dbus 
service, we may just be reloading without having made the changes ourselves, so 
we can't just cache the old value and restore it.
  
  That said, software-properties already times out on my oracular system.

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to software-properties in
Ubuntu.
https://bugs.launchpad.net/bugs/2069433

Title:
  Enabling new pockets does not enable deb-src for them, even if source
  code is enabled

Status in software-properties package in Ubuntu:
  Fix Released
Status in software-properties source package in Noble:
  Fix Committed

Bug description:
  [Impact]
  If you have Source Code enabled, and you change the pockets configuration to 
"all pockets", it will add -backports without source code. The Source Code flag 
will still be set in the UI, but after a reload, you can see it is in a mixed 
state.

  This is more notable now, because this splits up the deb822 paragraph
  into two: One for the deb, and one for deb-src, whereas it should
  remain one.

  [Test plan]
  1. Turn on source code, save and refresh sources, close app
  2. Start again, observe the flag is on.
  3. Turn "recommended updates" to "all updates", observe that -backports got 
added with deb-src (formerly this said: to the existing paragraph, this is now 
tracked in bug 2084568)
  4. Restart the app and observe that the flag is still on.

  [Where problems could occur]
  This incurs a performance regression, as we need to check the state of the 
source code flag after reloading sources. That said, this is of course 
necessary for the source code flag to be correct after reloading modified 
sources (it gets reset to False when reloading). And since we run in a dbus 
service, we may just be reloading without having made the changes ourselves, so 
we can't just cache the old value and restore it.

  That said, software-properties already times out on my oracular
  system.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/2069433/+subscriptions


-- 
Mailing list: https://launchpad.net/~touch-packages
Post to     : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to