Thank you for contributing the fix for this!
The changes look good to me and I'll accept these into jammy-proposed
shortly.
I would like a couple of things thought about with regard to testing
though please:
1) It's a hard requirement that a test be performed to ensure that the
package still works. Things in our build environment can change (eg.
build dependency changes), so it's not sufficient to verify this from
code changes alone. Users not caring about krb5 support would quite
reasonably be upset if we didn't test the update at all before releasing
it. Please add a smoke test (at a minimum) to the Test Plan to ensure
that normal use of the package still works at all. Using a reverse
dependency that exercises the library would be fine. If this is already
covered by automated testing then that's also fine - please point out
where that testing is though then please.
2) We're fixing krb5 support so it'd be nice to actually check that krb5
support fully works before releasing this, rather than find that there
was some other issue later. I recognise that you said:
> * I believe the fix is non-intrusive enough that no further testing
is needed.
...but if there's some other problem with krb5, then that wouldn't show
up.
Given that we're trying to fix krb5 for users, could we please ensure
that krb5 functionality is tested before we release this to jammy-
updates?
It's OK to combine these two requests into one test.
** Changed in: neon27 (Ubuntu)
Status: Confirmed => Fix Released
** Tags added: verification-needed verification-needed-jammy
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to neon27 in Ubuntu.
https://bugs.launchpad.net/bugs/2003266
Title:
22.04 package lacks GSSAPI support
Status in neon27 package in Ubuntu:
Fix Released
Status in neon27 source package in Jammy:
Fix Committed
Bug description:
[ Impact ]
* GSSAPI was disabled by accident as a side-effect of packaging a new
release.
Upstream renamed the environment variable used to setup the feature and the
flag was not updated in d/rules.
* Users get caught off-guard when updating from 20.04 to 22.04, 24.04 is not
affected.
[ Test Plan ]
* Did not test the binary, confirmed the fix is effective by analyzing the
build logs.
* I've confirmed that the issue
is solved by checking for the presence of the following string in the build
logs:
checking for krb5-config... /usr/bin/krb5-config.mit
Whereas a build with the issue will instead output:
checking for krb5-config... none
* I believe the fix is non-intrusive enough that no further testing
is needed.
[ Where problems could occur ]
* Enabling a new feature could have a side effect of disabling another
mutually-exclusive feature, but I did not identify any.
* Enabling a new feature could break a different feature which changes its
behavior when this new feature is present, I also did not identify any such
case.
[ Other Info ]
* Upstream bug reports:
- https://github.com/notroj/neon/issues/102
- https://github.com/notroj/neon/issues/52
* Upstream breaking change:
-
https://github.com/notroj/neon/commit/b9b7425de38b35249e689c03c30c8fd8adfae806
* Upstream change to avoid this from happening again:
-
https://github.com/notroj/neon/commit/4fdcff4a0ccbb0924f7dabcf8d213452aa33ab82
* Launchpad bug:
- https://bugs.launchpad.net/ubuntu/+source/neon27/+bug/2003266
[ Original description ]
For more information, please see
https://github.com/notroj/neon/issues/102.
The 22.04 built package of neon lacks GSSAPI support, whereas previous
versions (e.g. 18.04) had this support built-in. This appears to be
due to a recent-ish change in the build logic for neon, which changes
when GSSAPI is compiled in to the library
(https://github.com/notroj/neon/commit/b9b7425de38b35249e689c03c30c8fd8adfae806)
We were able to get a work around building from source with the
following envvar during build-time:
KRB5_CONF_TOOL=/usr/bin/krb5-config.mit ./configure. TL;DR:
KRB5_CONFIG became KRB5_CONF_TOOL.
Version information:
$ lsb_release -rd
Description: Ubuntu 22.04.1 LTS
Release: 22.04
$ apt show libneon27
Package: libneon27
Version: 0.32.2-1
Priority: optional
Section: universe/libs
Source: neon27
Origin: Ubuntu
Maintainer: Ubuntu Developers <ubuntu-devel-disc...@lists.ubuntu.com>
Original-Maintainer: Laszlo Boszormenyi (GCS) <g...@debian.org>
Bugs: https://bugs.launchpad.net/ubuntu/+filebug
Installed-Size: 233 kB
Depends: libc6 (>= 2.33), libssl3 (>= 3.0.0~~alpha1), libxml2 (>= 2.7.4),
zlib1g (>= 1:1.1.4)
Homepage: https://notroj.github.io/neon/
Download-Size: 102 kB
APT-Manual-Installed: no
APT-Sources: [corporate Launchpad mirror]
Description: HTTP and WebDAV client library
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/neon27/+bug/2003266/+subscriptions
--
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help : https://help.launchpad.net/ListHelp
