Hi Robert, thanks for the update to the description. I would like to see two things
1. (Like Paride, I don't have a SRU hat to wear) While this updated description elaborates on what has changed, it doesn't really go into the "what can go wrong" territory. This is an important field for SRU review as we want to consider how problems might manifest, if they are going to. In this case, we've got an upstream patch that has been around for a while. Have there been further upstream changes in this code area since? You can evaluate that to help establish some history. We're changing a calculation. The immediate calculation is improved, but what about similar ones? is `uptime -p` correct now for 51 weeks and 53? Similar things like that are good to consider. 2. It would be good to elaborate on the changelog, on what's going on. I think https://www.debian.org/doc/manuals/developers-reference/best- pkging-practices.html#writing-useful-changelog-entries is a good description of what sort of content is desired. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to procps in Ubuntu. https://bugs.launchpad.net/bugs/2035061 Title: uptime -p reports incorrect output after 52 weeks Status in procps package in Ubuntu: New Status in procps source package in Focal: New Status in procps source package in Jammy: New Bug description: [IMPACT] uptime will provide incorrect data after 52 weeks. This is at least confusing for users utilizing this tool. Issue is already fixed in upstream https://gitlab.com/procps-ng/procps/-/commit/8827c6763f79f77a126968e200b0e402de7cb749. Latest procps releases already include this patch (procps 4.0.3 lunar/mantic) The fix is needed for following set of packages: procps | 2:3.3.17-6ubuntu2 | jammy procps | 2:3.3.16-1ubuntu2 | focal [TEST CASE] UPTIME="31528920 31528800"; mkfifo uptime_fifo; while true; do cat <<<$UPTIME > uptime_fifo; done & sudo mount -obind uptime_fifo /proc/uptime uptime -p Running above commands will result in incorrect uptime output. [REGRESSION POTENTIAL] The patch is already available in upstream, lunar/mantic releases already include is as well. Old behavior will inaccurately print uptime -p for 24h after 31449600 seconds (0 years, 0 weeks). With new patch during that time uptime -p will print "52 weeks". [OTHER] Bug upstream: https://gitlab.com/procps-ng/procps/-/issues/217 Following patch is needed for older releases: https://gitlab.com/procps-ng/procps/-/commit/8827c6763f79f77a126968e200b0e402de7cb749 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/procps/+bug/2035061/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
