Focal amd64 dep8 run: https://autopkgtest.ubuntu.com/results/autopkgtest- focal/focal/amd64/i/iptables/20230516_045413_de974@/log.gz
It now contains a new dep8 test, labeled command17, which runs run- tests.sh: autopkgtest [04:53:52]: test command17: chmod +x ./iptables/tests/shell/testcases/chain/0006rename-segfault_0; cd iptables/tests/shell; ./run-tests.sh --host Which runs the shell test suite, including the test for bug #1992454: autopkgtest [04:53:52]: test command17: chmod +x ./iptables/tests/shell/testcases/chain/0006rename-segfault_0; cd iptables/tests/shell; ./run-tests.sh --host autopkgtest [04:53:52]: test command17: [----------------------- I: [EXECUTING] ././testcases/arptables/0001-arptables-save-restore_0 [1A[KI: [OK] ././testcases/arptables/0001-arptables-save-restore_0 (...) I: [EXECUTING] ././testcases/chain/0006rename-segfault_0 [1A[KI: [OK] ././testcases/chain/0006rename-segfault_0 (...) And this suite passes: (...) I: [EXECUTING] ././testcases/nft-only/0003delete-with-comment_0 [1A[KI: [OK] ././testcases/nft-only/0003delete-with-comment_0 I: nft results: [OK] 41 [FAILED] 0 [TOTAL] 41 I: combined results: [OK] 82 [FAILED] 0 [TOTAL] 82 autopkgtest [04:54:00]: test command17: -----------------------] autopkgtest [04:54:00]: test command17: - - - - - - - - - - results - - - - - - - - - - command17 PASS Focal verification succeeded. ** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to iptables in Ubuntu. https://bugs.launchpad.net/bugs/2019023 Title: Fix shell test suite Status in iptables package in Ubuntu: Fix Released Status in iptables source package in Focal: Fix Committed Bug description: [ Impact ] The shell test suite (iptables/tests/shell/run-tests.sh) is currently failing on the firewalld tests in focal only: W: [FAILED] ././testcases/firewalld-restore/0001-firewalld_0: expected 0 but got 1 W: [FAILED] ././testcases/firewalld-restore/0002-firewalld-restart_0: expected 0 but got 1 After some troubleshooting, it turns out this is happening because of an unsorted order in the output of iptables-save, which was fixed[1] in later releases of iptables. The code was trying to compensate for that, but there was a small mistake[2] in a case/esac globbing: case "$XT_MULTI" in -*/xtables-nft-multi) +*xtables-nft-multi) The upstream fix includes other similar changes in other tests, but in the case of focal, the above is the minimal fix needed. Note that this shell test suite is not being run in focal, just in later ubuntu releases. But since the fix for #1992454 is adding such a test, I decided to fix the shell test run and add it to the existing DEP8 tests for focal via this bug, so we have test parity between focal and later ubuntu releases. 1. https://git.netfilter.org/iptables/commit/?id=e28cf12cf50b9e2e0114f04331635fc122cb8aef 2. https://git.netfilter.org/iptables/commit/?id=2b2b7948c1960ba4680677664ff58477be869de6 [ Test Plan ] Verify that the DEP8 tests now include a run-tests.sh test suite, and that it passes. [ Where problems could occur ] If the fix is incorrect, it would affect only the already-failing firewalld test. But in addition to fixing that test, we are now also including a full test run of all shell tests, something which wasn't being done for focal until now. While these tests are passing now, they could fail in a future iptables SRU, or turn out to be flaky. They are being run in ubuntu releases after focal, though, so that is a good sign. [ Other Info ] This fix is being included in the same upload as bug #1992454. [ Original Description ] The shell test suite (iptables/tests/shell/run-tests.sh) is currently failing on the firewalld tests: W: [FAILED] ././testcases/firewalld-restore/0001-firewalld_0: expected 0 but got 1 W: [FAILED] ././testcases/firewalld-restore/0002-firewalld-restart_0: expected 0 but got 1 After some troubleshooting, it turns out this is happening because of an unsorted order in the output of iptables-save, which was fixed[1] in later releases of iptables. The code was trying to compensate for that, but there was a small mistake[2] in a case/esac globbing: case "$XT_MULTI" in -*/xtables-nft-multi) +*xtables-nft-multi) 1. https://git.netfilter.org/iptables/commit/?id=e28cf12cf50b9e2e0114f04331635fc122cb8aef 2. https://git.netfilter.org/iptables/commit/?id=2b2b7948c1960ba4680677664ff58477be869de6 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/iptables/+bug/2019023/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
