Thanks, I will start by sponsoring the fix to hirsute, small nitpicks comment to consider for the next time which I will fix for that round
- 1.2.4-1.1build1ubuntu1 is a bit akward as a version, if we add delta we usually replace 'build' by 'ubuntu', it becomes 1.2.4-1.1ubuntu1 - please include the upstream pull request reference in the patch itself - ' * conf: USB - add "Cmedia Audio" to USB-Audio.pcm.iec958_device (LP: #1921452)' is formatted like if a file name 'conf' was changed, remove the '*' there basically reformatted the changelog entry is ' * d/p/0001-conf-USB-add-Cmedia-Audio-to-USB-Audio.pcm.iec958_de.patch: conf: USB - add "Cmedia Audio" to USB-Audio.pcm.iec958_device (LP: #1921452)' -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to alsa-lib in Ubuntu. https://bugs.launchpad.net/bugs/1921452 Title: [SRU] alsa-lib: conf: USB - add "Cmedia Audio" to USB- Audio.pcm.iec958_device Status in OEM Priority Project: In Progress Status in alsa-lib package in Ubuntu: Fix Committed Status in alsa-lib source package in Focal: In Progress Status in alsa-lib source package in Groovy: In Progress Status in alsa-lib source package in Hirsute: Fix Committed Bug description: [Impact] On Cmedia Audio, unusable SPDIF can be selected as output from PulseAudio. [Fix] Disable IEC958 (SPDIF) through ALSA UCM. [Test] With the UCM applied, `pactl` and audio panel in gnome-control-center no longer have SPDIF option. [Where problems will occur] "Cmedia Audio" is the sound card name of this usb audio dongle, and this string is got from usb string descriptor, that is to say the "Cmedia Audio" is hard-coded in the firmware of that usb dongle. Not all Cmedia usb audio dongle use "Cmedia Audio", most of the dongles don't set string descriptor, then the audio driver sets a generic name "USB Audio Device" for them, if a dongle has string descriptor, it may have different string like "C-Media USB Headphone Set", and all dongles I met before don't have SPDIF interface. So If this SRU could introduce regression, it will happen on a Cmedia usb audio dongle which also hard-codes the "Cmedia Audio" in the string descriptor and it has SPDIF interface on it, after this SRU, users couldn't find the SPDIF playback device from the gnome-sound-setting. But this regression chance is very low since it is very rare a cmedia usb audio dongle uses "Cmedia Audio" in the string descriptor and it is very rare a usb audio dongle has SPDIF interface. So far we haven't met such a cmedia usb audio dongle. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1921452/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp