Launchpad has imported 34 comments from the remote bug at https://bugs.freedesktop.org/show_bug.cgi?id=81382.
If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. ------------------------------------------------------------------------ On 2014-07-15T11:25:08+00:00 Vda-linux wrote: Created attachment 102847 dmesg I log in as root on a text virtual console. After about 10 minutes screen blanks. Surprisingly, pressing a key does *not* unblank the screen! Machine is still alive (I can ssh into it), and typed keys even reach the console: I can type e.g. "ls -lR /usr" and I see disk indicator blinking, ls process is visible in the ps in ssh session, etc. This does not happen in X. This is observed on Lenovo T60, on RHEL7 kernel and also on recent upstream kernel 3.15.5. Investigation had revealed that VT unblanking code, after all the hard work it done to turn display back on, calls ATOM_LCD_BLOFF (backlight off, numeric value 2) function. Digging further, I discovered that fb_blank(blank=0) almost at its end calls fb_notifier_call_chain(FB_EVENT_BLANK). Which calls backlight.c::fb_notifier_callback(), which tries to set brightness via radeon_atom_backlight_update_status(), which does atombios_set_backlight_level(radeon_atom_bl_level()), but radeon_atom_bl_level() is zero (it's an uint8_t, brightness level). So it's essentially atombios_set_backlight_level(0) and it switches backlight off. In drivers/gpu/drm/radeon/*, bd->props.brightness, surprisingly, is only set in radeon_atom_backlight_init() and radeon_legacy_backlight_init(), all other locations are only reading it. So, if this init code sets it to 0, then VT unblanking code will use this zero value as brightness to restore, causing this bug. And indeed, that's what happens on the machine exhibiting this bug: [ 2.301563] radeon_atom_get_backlight_level_from_reg: RADEON_BIOS_2_SCRATCH [ 2.301633] radeon_atom_get_backlight_level_from_reg: bios_2_scratch:00000000 [ 2.301704] radeon_atom_backlight_init: bd->props.brightness=0 [ 2.301780] radeon_atom_backlight_update_status: atombios_set_back The full dmesg of the RHEL7 boot with many debug printks added is attached. (Sorry, I started debugging it on RHEL7, I believe mainline does not differ significantly). It shows the following: After "setterm -blank 1 && sleep 60", VT blanking triggers at ~362 seconds, and at ~370 seconds VT is trying to unblank because of keyboard activity. The bug is evident here: [ 370.852058] fb_blank: fb_notifier_call_chain(FB_EVENT_BLANK)... [ 370.852061] fbcon_event_notify: case FB_EVENT_BLANK: fbcon_fb_blanked(blank:0) [ 370.852063] fbcon_fb_blanked: do_unblank_screen(0) [ 370.852064] do_unblank_screen: entered on cpu 0 [ 370.852066] do_unblank_screen: !console_blanked on cpu 0 [ 370.852068] backlight: drivers/video/backlight/backlight.c:fb_notifier_callback: backlight_update_status() [ 370.852071] radeon_atom_backlight_update_status: atombios_set_backlight_level() [ 370.852072] radeon_atom_bl_level: level = bd->props.brightness:0 [ 370.852074] atombios_set_backlight_level(level:0) [ 370.852077] atombios_set_backlight_level: atom_execute_table(ATOM_LCD_BLOFF) ^^^^^^^^^^^^^^^^^^^^ THIS TURNS OFF DISPLAY ^^^^^^^^^^^^^^^^^ [ 370.852083] atom_execute_table_locked(index:23,*params:ffff8802) returns 0 [ 370.852085] backlight: drivers/video/backlight/backlight.c:fb_notifier_callback: backlight_update_status() [ 370.852940] fb_blank returns 0 [ 370.852942] fbcon_blank: update_screen()... [ 370.862313] do_unblank_screen: done on cpu 0 Note: PCI error seen during blanking is not causing this bug. It happens on first blanking (including Xserver screen blankings, which do not exhibit this bug), and never repeats. Google says it's a known issue on Radeon, comes from PCIe lanes reconfiguration. I am unsure how to proceed from here. Maybe init code needs fixing to properly read backlight brightness on this hardware? I think radeon people are more qualified to take it from here. I'm willing to test patches. Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/0 ------------------------------------------------------------------------ On 2014-07-15T12:29:47+00:00 Vda-linux wrote: Created attachment 102852 Debugging messages patch Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/1 ------------------------------------------------------------------------ On 2014-07-15T13:37:37+00:00 agd5f wrote: *** Bug 70207 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/2 ------------------------------------------------------------------------ On 2014-07-15T13:55:27+00:00 agd5f wrote: Created attachment 102856 set the default backlight level to something reasonable Does this patch help? Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/3 ------------------------------------------------------------------------ On 2014-07-15T14:24:44+00:00 Vda-linux wrote: (In reply to comment #3) > Created attachment 102856 [details] [review] > set the default backlight level to something reasonable > > Does this patch help? Yes, it does. Maybe add a comment there why this check is necessary? Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/4 ------------------------------------------------------------------------ On 2014-07-15T14:33:23+00:00 agd5f wrote: Will do. Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/5 ------------------------------------------------------------------------ On 2014-07-16T18:26:11+00:00 6-david-p wrote: Work perfectly on Toshiba A210-15j! Tested-by: David Heidelberger <david.heidelber...@ixit.cz> Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/6 ------------------------------------------------------------------------ On 2014-09-05T20:58:58+00:00 6-david-p wrote: Ok, this fix work, but cause another problem (tested with 3.15.5+patch and 3.16.1). When display goes off, backlight goes off. When display goes on, backlight is set to MAX. When display goes off again, backligh remains MAX. After pressing key, LCD works, backlight stay at MAX level. When display goes off, backlight is still MAX. Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/9 ------------------------------------------------------------------------ On 2014-09-10T20:34:05+00:00 Daniel-kirsten-72 wrote: The above patch causes a problem on my Amilo Xi 2550 (RadeonHD 2600). The behaviour for kernel-3.14.8-100.fc19 (without patch): The value of /sys/class/backlight/radeon_bl0/brightness is 0. Whenever I write something (0-255) to /sys/class/backlight/radeon_bl0/brightness, the backlight is turned off, and I am not able to turn on the backlight again. However, I can still shutdown the system (Ctr+Alt+Fx, login as root, and give a shutdown command. I can control the backlight by writing values 0-7 to /sys/class/backlight/acpi_video0/brightness. The behaviour for kernel-3.14.17-100.fc19 (with patch): The backlight is turned off during the boot up process, when the kernel switches into graphics mode. I commented out the lines 233-234 in drivers/gpu/drm/radeon/atombios_encoders.c, and then, the problem disappeared, i.e., the backlight stays on when the kernel switches into graphics mode. Best regards, Daniel Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/10 ------------------------------------------------------------------------ On 2014-09-11T10:42:35+00:00 Vda-linux wrote: (In reply to comment #7) > Ok, this fix work, but cause another problem (tested with 3.15.5+patch and > 3.16.1). > > When display goes off, backlight goes off. > When display goes on, backlight is set to MAX. > When display goes off again, backligh remains MAX. > After pressing key, LCD works, backlight stay at MAX level. > When display goes off, backlight is still MAX. I would say it means that merely treating backlight value of 0 as MAX is not the best idea. Maybe we need an additional bool variable "failed to read initial BL value, don't ever try to set it", set it if initial read of BL value is 0, and if it is set, never try to change BL level? Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/11 ------------------------------------------------------------------------ On 2014-09-11T13:58:49+00:00 agd5f wrote: (In reply to comment #7) > Ok, this fix work, but cause another problem (tested with 3.15.5+patch and > 3.16.1). > > When display goes off, backlight goes off. > When display goes on, backlight is set to MAX. > When display goes off again, backligh remains MAX. > After pressing key, LCD works, backlight stay at MAX level. > When display goes off, backlight is still MAX. Does the backlight respond correctly when adjusted via the sysfs blacklight interface? Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/12 ------------------------------------------------------------------------ On 2014-09-12T22:40:45+00:00 Ps wrote: I've got the same notebook as Daniel Kirsten, so I've searched for changes in the kernel code, which caused the dark screen. From that point, I've found the patch from Alex Deucher and this bug report. If I change /sys/class/backlight/radeon_bl0/brightness or /sys/class/backlight/acpi_video0 the display stayes dark. @Alex is this what you wanted to know? If not, please let me know, how I could help you to debug this problem! Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/13 ------------------------------------------------------------------------ On 2014-09-13T20:43:24+00:00 Daniel-kirsten-72 wrote: (In reply to comment #11) > I've got the same notebook as Daniel Kirsten, They sold different Amilo Xi 2550, there are even some Amilo Xi 2550 with an Nvidia graphic card. > If I change /sys/class/backlight/radeon_bl0/brightness or > /sys/class/backlight/acpi_video0 the display stayes dark. I can control brightness by writing 0-7 into /sys/class/backlight/acpi_video0/brightness You should comment out lines 233-234 in drivers/gpu/drm/radeon/atombios_encoders.c, i.e., /* if (bd->props.brightness == 0) 234 bd->props.brightness = RADEON_MAX_BL_LEVEL; */ then it works. Daniel Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/14 ------------------------------------------------------------------------ On 2014-09-15T20:41:54+00:00 Ps wrote: (In reply to comment #12) Hi Daniel, correct, before that patch, the display was controllable through /sys/class/backlight/acpi_video0/brightness. After that patch, the display is always dark. The only change which was done by Alex, was adding the lines, which you commeted out. (If I understood the code correct, the other two lines, which were removed, are obsolete and not needed). So if you removed that two lines, then you've got the same code as before and our Amilo (with ATI card) is working fine, but Denys problem will appear again... Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/15 ------------------------------------------------------------------------ On 2014-09-15T20:47:50+00:00 agd5f wrote: (In reply to comment #11) > If I change /sys/class/backlight/radeon_bl0/brightness or > /sys/class/backlight/acpi_video0 the display stayes dark. > > @Alex > is this what you wanted to know? If not, please let me know, how I could > help you to debug this problem! Without the patch from this bug report applied (e.g., when your display is working), which, if any, of the blacklight interfaces work? It seems like perhaps your laptop claims to have a GPU controlled backlight, but really uses an external backlight control. Can you attach a copy of your vbios? TO get a copy of your vbios: (as root) (use lspci to get the bus id) cd /sys/bus/pci/devices/<pci bus id> echo 1 > rom cat rom > /tmp/vbios.rom echo 0 > rom Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/16 ------------------------------------------------------------------------ On 2014-09-16T07:00:00+00:00 Ps wrote: Created attachment 106353 lspci output for amilo Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/17 ------------------------------------------------------------------------ On 2014-09-16T07:01:41+00:00 Ps wrote: Created attachment 106354 vbios from Amilo Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/18 ------------------------------------------------------------------------ On 2014-09-16T07:17:24+00:00 Ps wrote: (In reply to comment #14) This could be true. I can control it via /sys/class/backlight/acpi_video0/brightness. If I change /sys/class/backlight/radeon_bl0/brightness then the display is nearly black and cannot be restored. After reboot the following values are set: acpi_video0 = 7 radeon_bl0 = 0 I've attached a lspci -vvv to " lspci output for amilo" and the vbios to "vbios from Amilo" Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/19 ------------------------------------------------------------------------ On 2014-09-17T01:04:59+00:00 agd5f wrote: Can you attach the lspci -vnn output for your GPU? Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/20 ------------------------------------------------------------------------ On 2014-09-17T07:07:13+00:00 Ps wrote: Created attachment 106410 lspci -vnn for Amilo sure, here it is Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/21 ------------------------------------------------------------------------ On 2014-09-17T15:38:50+00:00 agd5f wrote: Created attachment 106441 patch 1/2 Do the attached patches help? The first patch adds a backlight module parameter to disable the gpu backlight device for testing. The second adds a quirk for the Amilo laptop. Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/22 ------------------------------------------------------------------------ On 2014-09-17T15:39:17+00:00 agd5f wrote: Created attachment 106442 patch 2/2 Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/23 ------------------------------------------------------------------------ On 2014-09-17T16:42:07+00:00 Ps wrote: Thanks for the patch, but I'm on vacation till 26th September, so long I cannot test it. @Daniel As you've got the same problem, could you test the patches? Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/24 ------------------------------------------------------------------------ On 2014-09-18T07:54:57+00:00 Daniel-kirsten-72 wrote: I can test the patches from 2014-09-17 on my amilo. Can I apply them to the current fedora kernel code 3.14.18-100? Should I apply both patches or test each patch separately? Daniel Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/25 ------------------------------------------------------------------------ On 2014-09-18T13:09:02+00:00 agd5f wrote: Apply them both together. Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/26 ------------------------------------------------------------------------ On 2014-09-18T13:10:28+00:00 agd5f wrote: (In reply to comment #24) > Apply them both together. Well, assuming your laptop has the same pci ids as Patrick. If not, just append radeon.backlight=0 to the kernel command line in grub and attach your lspci -vnn output. Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/27 ------------------------------------------------------------------------ On 2014-09-18T19:27:12+00:00 Daniel-kirsten-72 wrote: (In reply to comment #25) The pci-id of the VGA Controller is 01:00.0 for my Amilo. However, I cannot apply the patches to the 3.14.18-100.fc19 kernel: patch --dry-run -p1 < ~/software/0001-drm-radeon-add-a-module-parameter-for-backlight-cont.patch checking file drivers/gpu/drm/radeon/radeon.h Hunk #1 FAILED at 106. 1 out of 1 hunk FAILED checking file drivers/gpu/drm/radeon/radeon_drv.c Hunk #1 FAILED at 181. Hunk #2 succeeded at 237 with fuzz 2 (offset -26 lines). 1 out of 2 hunks FAILED checking file drivers/gpu/drm/radeon/radeon_encoders.c Exit 1 patch --dry-run -p1 < ~/software/0002-drm-radeon-add-a-backlight-quirk-for-Amilo-Xi-2550.patch checking file drivers/gpu/drm/radeon/radeon_encoders.c Hunk #1 FAILED at 173. 1 out of 1 hunk FAILED Exit 1 Which kernel should I use to test the patches? Daniel Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/28 ------------------------------------------------------------------------ On 2014-09-18T19:28:36+00:00 agd5f wrote: They are written against 3.17. Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/29 ------------------------------------------------------------------------ On 2014-09-19T13:14:21+00:00 agd5f wrote: (In reply to comment #26) > (In reply to comment #25) > > The pci-id of the VGA Controller is 01:00.0 for my Amilo. That's the bus id. I need the output of lspci -vnn Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/30 ------------------------------------------------------------------------ On 2014-09-19T15:38:49+00:00 Daniel-kirsten-72 wrote: I tested the patches from 2014-09-17 against 3.17-rc5. When I applied both patches, the backlight was not turned off, when the kernel switched into graphics mode. The kernel worked very well. Without the patches, the backlight was turned off, when the kernel switched into graphics mode. Daniel Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/31 ------------------------------------------------------------------------ On 2014-09-19T15:40:46+00:00 Daniel-kirsten-72 wrote: Created attachment 106554 lspci -vnn for Daniel's amilo Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/32 ------------------------------------------------------------------------ On 2014-09-19T16:20:53+00:00 agd5f wrote: (In reply to comment #30) > Created attachment 106554 [details] > lspci -vnn for Daniel's amilo You have the same configuration as Patrick. (In reply to comment #29) > I tested the patches from 2014-09-17 against 3.17-rc5. > > When I applied both patches, the backlight was not turned off, when the > kernel switched into graphics mode. > The kernel worked very well. Great. I'll make sure the patches get upstream. Thanks for testing. Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/33 ------------------------------------------------------------------------ On 2014-09-27T21:36:16+00:00 Ps wrote: I've just tested the patches on my notebook, too. Also here, the problem is fixed, with the patches you provided. Do you already know, in which upstream versions, the fix will be published? 3.17? Or in an 3.16.x already? Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/34 ------------------------------------------------------------------------ On 2014-09-28T00:40:20+00:00 Dieter-nuetzel-hh wrote: They are in Linus 3.17 tree: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=005f800508eb391480f463dad3d54e5b4ec67d57 Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1363623/comments/35 ** Changed in: xserver-xorg-driver-radeonhd Status: Unknown => Confirmed ** Changed in: xserver-xorg-driver-radeonhd Importance: Unknown => Medium -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to xorg in Ubuntu. https://bugs.launchpad.net/bugs/1363623 Title: [ASUS-A7K laptop] screen brightness dimmed after kernel update Status in xserver-xorg-driver-radeonhd: Confirmed Status in “xorg” package in Ubuntu: New Bug description: Hello, Following the update from kernel version 3.13.0-34 to 3.13.0-35-generic the screen brightness got a lot dimmer. The Fn+F5/F6 control keys still work, in that the display gets dimmer and brighter, but the maximum brightness is too low. When starting ubuntu using the previous kernel release the display brightness is alright. I've looked around the web for ways to change the display brightness and I checked that both files "/sys/class/backlight/acpi_video0/brightness" and "/sys/class/backlight/radeon_bl0/brightness" have the maximum values, 15 and 255 respectively. The release I am running is : Ubuntu 14.04.1 LTS The XORG package version is : 1:7.7+1ubuntu8 Please feel free to contact me for any further information. ProblemType: Bug DistroRelease: Ubuntu 14.04 Package: xorg 1:7.7+1ubuntu8 ProcVersionSignature: Ubuntu 3.13.0-35.62-generic 3.13.11.6 Uname: Linux 3.13.0-35-generic x86_64 .tmp.unity.support.test.0: ApportVersion: 2.14.1-0ubuntu3.3 Architecture: amd64 CompizPlugins: No value set for `/apps/compiz-1/general/screen0/options/active_plugins' CompositorRunning: None CurrentDesktop: GNOME Date: Sun Aug 31 11:40:07 2014 DistUpgraded: Fresh install DistroCodename: trusty DistroVariant: ubuntu ExtraDebuggingInterest: Yes, if not too technical GraphicsCard: Advanced Micro Devices, Inc. [AMD/ATI] RV630/M76 [Mobility Radeon HD 2600] [1002:9581] (prog-if 00 [VGA controller]) Subsystem: ASUSTeK Computer Inc. Device [1043:1562] InstallationDate: Installed on 2014-07-24 (38 days ago) InstallationMedia: Ubuntu 14.04 LTS "Trusty Tahr" - Release amd64 (20140417) MachineType: ASUSTeK Computer Inc. A7K ProcEnviron: TERM=xterm PATH=(custom, no user) XDG_RUNTIME_DIR=<set> LANG=fr_FR.UTF-8 SHELL=/bin/bash ProcKernelCmdLine: BOOT_IMAGE=/vmlinuz-3.13.0-35-generic root=/dev/mapper/vg_a7k-lv_root ro quiet splash vt.handoff=7 SourcePackage: xorg Symptom: display UpgradeStatus: No upgrade log present (probably fresh install) dmi.bios.date: 07/25/2007 dmi.bios.vendor: American Megatrends Inc. dmi.bios.version: A7KAS.2 dmi.board.asset.tag: ATN12345678901234567 dmi.board.name: A7K dmi.board.vendor: ASUSTeK Computer Inc. dmi.board.version: 1.0 dmi.chassis.type: 10 dmi.chassis.vendor: ASUSTeK Computer Inc. dmi.modalias: dmi:bvnAmericanMegatrendsInc.:bvrA7KAS.2:bd07/25/2007:svnASUSTeKComputerInc.:pnA7K:pvr1.0:rvnASUSTeKComputerInc.:rnA7K:rvr1.0:cvnASUSTeKComputerInc.:ct10:cvr: dmi.product.name: A7K dmi.product.version: 1.0 dmi.sys.vendor: ASUSTeK Computer Inc. version.compiz: compiz 1:0.9.11.2+14.04.20140714-0ubuntu1 version.ia32-libs: ia32-libs N/A version.libdrm2: libdrm2 2.4.52-1 version.libgl1-mesa-dri: libgl1-mesa-dri 10.1.3-0ubuntu0.1 version.libgl1-mesa-dri-experimental: libgl1-mesa-dri-experimental N/A version.libgl1-mesa-glx: libgl1-mesa-glx 10.1.3-0ubuntu0.1 version.xserver-xorg-core: xserver-xorg-core 2:1.15.1-0ubuntu2 version.xserver-xorg-input-evdev: xserver-xorg-input-evdev 1:2.8.2-1ubuntu2 version.xserver-xorg-video-ati: xserver-xorg-video-ati 1:7.3.0-1ubuntu3.1 version.xserver-xorg-video-intel: xserver-xorg-video-intel 2:2.99.910-0ubuntu1 version.xserver-xorg-video-nouveau: xserver-xorg-video-nouveau 1:1.0.10-1ubuntu2 xserver.bootTime: Sun Aug 31 11:06:06 2014 xserver.configfile: default xserver.errors: xserver.logfile: /var/log/Xorg.0.log xserver.version: 2:1.15.1-0ubuntu2 xserver.video_driver: radeon To manage notifications about this bug go to: https://bugs.launchpad.net/xserver-xorg-driver-radeonhd/+bug/1363623/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
