** Description changed: [Impact] We would like to include a cloud_id/$name parameter to the user-agent string that is sent to https://motd.ubuntu.com. This will allow the server part of motd.ubuntu.com to serve cloud-specific content if one is available. + [Test Case] + a) confirm that the motd message is still displayed: + $ sudo sh /etc/update-motd.d/50-motd-news --force - [Test Case] + * Kata Containers are now fully integrated in Charmed Kubernetes 1.16! + Yes, charms take the Krazy out of K8s Kata Kluster Konstruction. - * detailed instructions how to reproduce the bug + https://ubuntu.com/kubernetes/docs/release-notes - * these should allow someone who is not familiar with the affected - package to reproduce the bug and verify that the updated package fixes - the problem. + b) confirm that cloud_id is set in the user-agent. This should be tested + in lxd, gce, aws, and azure. Here is an example for lxd: + + $ sudo sh -x /etc/update-motd.d/50-motd-news --force 2>&1| grep -E "curl .*cloud_id/" + + curl --connect-timeout 60 --max-time 60 -A curl/7.47.0-1ubuntu2.14 Ubuntu/16.04.6/LTS GNU/Linux/4.15.0-64-generic/x86_64 Intel(R)/Core(TM)/i7-7600U/CPU/@/2.80GHz uptime/921.00/900.00 cloud_id/lxd -o- https://motd.ubuntu.com + + For each of the mentioned clouds, we expect cloud_id to be set to their + short names: aws, gce, azure. [Regression Potential] + This change adds a new parameter to the already existing user-agent string. This relies on the cloud-id tool from cloud-init. Even though it's considered trusted to some degree, it may be possible for some clouds to override their name in the data fed to cloud-init, which is what cloud-id parses. Therefore some precautions were taken when handling its contents: + - set value to unknown if cloud-id fails, doesn't exist, or produce an empty value + - sanitize the output of cloud-id, and truncate it to a maximum length + - use a tempfile to store the intermediate output of cloud-id instead of a shell variable. One reason being avoiding storing a potentially large amount of data in a shell variable, and the other is to avoid mistakes when manipulating a shell variable that could contain shell metacharacters. - * discussion of how regressions are most likely to manifest as a result - of this change. - - * It is assumed that any SRU candidate patch is well-tested before - upload and has a low overall risk of regression, but it's important - to make the effort to think about what ''could'' happen in the - event of a regression. - - * This both shows the SRU team that the risks have been considered, - and provides guidance to testers in regression-testing the SRU. [Other Info] - - * Anything else you think is useful to include - * Anticipate questions from users, SRU, +1 maintenance, security teams and the Technical Board - * and address these questions in advance + For xenial, this is also finishing the fix for bug #1637800 which was stuck in the SRU queue due to it failing checks. Since the xenial package isn't using debhelper, manual dh snippets were added to the maintainer scripts, but they missed the dh_systemd_enable chunks. I'm also skipping starting motd-news.service, since the timer unit will handle that. This avoids an annoying error message about trying to start a unit that is not enabled. [Original Description] I'm preemptively filing this bug in case this isn't uploaded before the feature freeze. We would like to include a cloud_id/$name parameter to the user-agent string that is sent to https://motd.ubuntu.com. This will allow the server part of motd.ubuntu.com to serve cloud-specific content if one is available. There is an MP for this already at https://code.launchpad.net/~ahasenack/ubuntu/+source/base-files/+git /base-files/+merge/371370
** Description changed: [Impact] We would like to include a cloud_id/$name parameter to the user-agent string that is sent to https://motd.ubuntu.com. This will allow the server part of motd.ubuntu.com to serve cloud-specific content if one is available. [Test Case] a) confirm that the motd message is still displayed: $ sudo sh /etc/update-motd.d/50-motd-news --force - * Kata Containers are now fully integrated in Charmed Kubernetes 1.16! - Yes, charms take the Krazy out of K8s Kata Kluster Konstruction. + * Kata Containers are now fully integrated in Charmed Kubernetes 1.16! + Yes, charms take the Krazy out of K8s Kata Kluster Konstruction. - https://ubuntu.com/kubernetes/docs/release-notes + https://ubuntu.com/kubernetes/docs/release-notes b) confirm that cloud_id is set in the user-agent. This should be tested in lxd, gce, aws, and azure. Here is an example for lxd: $ sudo sh -x /etc/update-motd.d/50-motd-news --force 2>&1| grep -E "curl .*cloud_id/" + curl --connect-timeout 60 --max-time 60 -A curl/7.47.0-1ubuntu2.14 Ubuntu/16.04.6/LTS GNU/Linux/4.15.0-64-generic/x86_64 Intel(R)/Core(TM)/i7-7600U/CPU/@/2.80GHz uptime/921.00/900.00 cloud_id/lxd -o- https://motd.ubuntu.com For each of the mentioned clouds, we expect cloud_id to be set to their short names: aws, gce, azure. + For xenial, there is an extra test case: + c) list the timers to confirm motd-news is active, and will run sometime in the next 12h following the installation of the updated package: + $ systemctl list-timers + NEXT LEFT LAST PASSED UNIT ACTIVATES + Mon 2019-09-30 19:38:55 UTC 6h left n/a n/a motd-news.timer motd-news.service + Mon 2019-09-30 22:45:13 UTC 9h left n/a n/a apt-daily.timer apt-daily.service + Tue 2019-10-01 06:12:11 UTC 16h left n/a n/a apt-daily-upgrade.timer apt-daily-upgrade.service + Tue 2019-10-01 13:11:41 UTC 23h left Mon 2019-09-30 13:11:41 UTC 14min ago systemd-tmpfiles-clean.timer systemd-tmpfiles-clean.service + [Regression Potential] This change adds a new parameter to the already existing user-agent string. This relies on the cloud-id tool from cloud-init. Even though it's considered trusted to some degree, it may be possible for some clouds to override their name in the data fed to cloud-init, which is what cloud-id parses. Therefore some precautions were taken when handling its contents: - set value to unknown if cloud-id fails, doesn't exist, or produce an empty value - sanitize the output of cloud-id, and truncate it to a maximum length - use a tempfile to store the intermediate output of cloud-id instead of a shell variable. One reason being avoiding storing a potentially large amount of data in a shell variable, and the other is to avoid mistakes when manipulating a shell variable that could contain shell metacharacters. - [Other Info] For xenial, this is also finishing the fix for bug #1637800 which was stuck in the SRU queue due to it failing checks. Since the xenial package isn't using debhelper, manual dh snippets were added to the maintainer scripts, but they missed the dh_systemd_enable chunks. I'm also skipping starting motd-news.service, since the timer unit will handle that. This avoids an annoying error message about trying to start a unit that is not enabled. [Original Description] I'm preemptively filing this bug in case this isn't uploaded before the feature freeze. We would like to include a cloud_id/$name parameter to the user-agent string that is sent to https://motd.ubuntu.com. This will allow the server part of motd.ubuntu.com to serve cloud-specific content if one is available. There is an MP for this already at https://code.launchpad.net/~ahasenack/ubuntu/+source/base-files/+git /base-files/+merge/371370 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to base-files in Ubuntu. https://bugs.launchpad.net/bugs/1840946 Title: Include cloud-id in user-agent string Status in base-files package in Ubuntu: Fix Released Status in base-files source package in Xenial: In Progress Status in base-files source package in Bionic: In Progress Status in base-files source package in Disco: In Progress Bug description: [Impact] We would like to include a cloud_id/$name parameter to the user-agent string that is sent to https://motd.ubuntu.com. This will allow the server part of motd.ubuntu.com to serve cloud-specific content if one is available. [Test Case] a) confirm that the motd message is still displayed: $ sudo sh /etc/update-motd.d/50-motd-news --force * Kata Containers are now fully integrated in Charmed Kubernetes 1.16! Yes, charms take the Krazy out of K8s Kata Kluster Konstruction. https://ubuntu.com/kubernetes/docs/release-notes b) confirm that cloud_id is set in the user-agent. This should be tested in lxd, gce, aws, and azure. Here is an example for lxd: $ sudo sh -x /etc/update-motd.d/50-motd-news --force 2>&1| grep -E "curl .*cloud_id/" + curl --connect-timeout 60 --max-time 60 -A curl/7.47.0-1ubuntu2.14 Ubuntu/16.04.6/LTS GNU/Linux/4.15.0-64-generic/x86_64 Intel(R)/Core(TM)/i7-7600U/CPU/@/2.80GHz uptime/921.00/900.00 cloud_id/lxd -o- https://motd.ubuntu.com For each of the mentioned clouds, we expect cloud_id to be set to their short names: aws, gce, azure. For xenial, there is an extra test case: c) list the timers to confirm motd-news is active, and will run sometime in the next 12h following the installation of the updated package: $ systemctl list-timers NEXT LEFT LAST PASSED UNIT ACTIVATES Mon 2019-09-30 19:38:55 UTC 6h left n/a n/a motd-news.timer motd-news.service Mon 2019-09-30 22:45:13 UTC 9h left n/a n/a apt-daily.timer apt-daily.service Tue 2019-10-01 06:12:11 UTC 16h left n/a n/a apt-daily-upgrade.timer apt-daily-upgrade.service Tue 2019-10-01 13:11:41 UTC 23h left Mon 2019-09-30 13:11:41 UTC 14min ago systemd-tmpfiles-clean.timer systemd-tmpfiles-clean.service [Regression Potential] This change adds a new parameter to the already existing user-agent string. This relies on the cloud-id tool from cloud-init. Even though it's considered trusted to some degree, it may be possible for some clouds to override their name in the data fed to cloud-init, which is what cloud-id parses. Therefore some precautions were taken when handling its contents: - set value to unknown if cloud-id fails, doesn't exist, or produce an empty value - sanitize the output of cloud-id, and truncate it to a maximum length - use a tempfile to store the intermediate output of cloud-id instead of a shell variable. One reason being avoiding storing a potentially large amount of data in a shell variable, and the other is to avoid mistakes when manipulating a shell variable that could contain shell metacharacters. [Other Info] For xenial, this is also finishing the fix for bug #1637800 which was stuck in the SRU queue due to it failing checks. Since the xenial package isn't using debhelper, manual dh snippets were added to the maintainer scripts, but they missed the dh_systemd_enable chunks. I'm also skipping starting motd-news.service, since the timer unit will handle that. This avoids an annoying error message about trying to start a unit that is not enabled. [Original Description] I'm preemptively filing this bug in case this isn't uploaded before the feature freeze. We would like to include a cloud_id/$name parameter to the user-agent string that is sent to https://motd.ubuntu.com. This will allow the server part of motd.ubuntu.com to serve cloud-specific content if one is available. There is an MP for this already at https://code.launchpad.net/~ahasenack/ubuntu/+source/base-files/+git /base-files/+merge/371370 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1840946/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
