Based on the below items, and the assumption that there is nobody
currently available to actually manually verify this for disco, I'm
marking this as verification-done-disco, although I have not personally
verified it for disco. I leave it up to ~ubuntu-sru team to decide if
this is enough to release the package to disco-updates.
1. existing verification of this patch for bionic (comment 14)
2. the modemmanager codebase being almost identical between bionic and disco:
modemmanager | 1.10.0-1~ubuntu18.04.2 | bionic-updates | source, amd64,
arm64, armhf, i386, ppc64el, s390x
modemmanager | 1.10.0-1ubuntu0.19.04.1 | disco-proposed | source, amd64,
arm64, armhf, i386, ppc64el, s390x
$ git diff --stat pkg/ubuntu/bionic-devel..pkg/ubuntu/disco-devel
debian/changelog | 14 ++++++-------
debian/libmm-glib0.symbols | 236
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------------------------------------------------------------------
debian/patches/error-propagation-fix.patch | 2 +-
3 files changed, 125 insertions(+), 127 deletions(-)
3. the simplicity and obviousness of the patch:
--- a/src/mm-broadband-modem.c
+++ b/src/mm-broadband-modem.c
@@ -8231,7 +8231,7 @@
GError *inner_error = NULL;
gboolean value;
- value = g_task_propagate_boolean (G_TASK (res), error);
+ value = g_task_propagate_boolean (G_TASK (res), &inner_error);
if (inner_error) {
g_propagate_error (error, inner_error);
return FALSE;
** Tags removed: verification-needed
** Tags added: verification-done-disco
** Tags removed: verification-needed-disco
** Tags added: verification-done
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to modemmanager in Ubuntu.
https://bugs.launchpad.net/bugs/1828102
Title:
Regression in ModemManager
Status in modemmanager package in Ubuntu:
Fix Released
Status in modemmanager source package in Bionic:
Fix Released
Status in modemmanager source package in Cosmic:
Won't Fix
Status in modemmanager source package in Disco:
Fix Committed
Status in modemmanager source package in Eoan:
Fix Released
Bug description:
[Impact]
ModemManager disconnects from CDMA modem after 30 sec failing to check
signal status due to incorrect error handling
[Test case]
connect to a cdma device without an extra AT channel (Eg. Samsung
brightside phone) and modemmanager will terminate the connection
[Regression potential]
The patch is tiny, fixing an obvious overlook, and it only affects
CDMA broadband modems, so the risk of a regression is very low.
[Original description]
ModemManager disconnects after ~30 sec
caused by a typo in 1.8
see https://bugs.launchpad.net/ubuntu/+source/modemmanager/+bug/1819615
and
https://gitlab.freedesktop.org/mobile-broadband/ModemManager/issues/119
for details
needs a SRU for cosmic and dingo
patch attached
yechiel
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/modemmanager/+bug/1828102/+subscriptions
--
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help : https://help.launchpad.net/ListHelp
