** Description changed:
[Impact]
json hooks ending with EPIPE on first read fail, but should simply do
nothing.This causes spurious failures of uninstalled hooks.
[Test case]
- TODO
+ Cannot generate one. This was discovered by snapd ci, but I did not find a
reproducer yet.
+
+ FWIW, the change should be tiny enough to see that it is not wrong:
+ - if (errno != ECONNRESET)
+ + if (errno != ECONNRESET && errno != EPIPE)
+ _error->Error("Could not read response to hello message from hook
%s: %s", Opts->Value.c_str(), strerror(errno));
+
+
[Regression potential]
- meh
+ JSON hooks failures with EPIPE are now ignored, so if it fails with EPIPE for
other reasons than just exiting, I guess we might miss it
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to apt in Ubuntu.
https://bugs.launchpad.net/bugs/1814543
Title:
deal with EPIPE from json hooks
Status in apt package in Ubuntu:
Fix Released
Bug description:
[Impact]
json hooks ending with EPIPE on first read fail, but should simply do
nothing.This causes spurious failures of uninstalled hooks.
[Test case]
Cannot generate one. This was discovered by snapd ci, but I did not find a
reproducer yet.
FWIW, the change should be tiny enough to see that it is not wrong:
- if (errno != ECONNRESET)
+ if (errno != ECONNRESET && errno != EPIPE)
_error->Error("Could not read response to hello message from hook
%s: %s", Opts->Value.c_str(), strerror(errno));
[Regression potential]
JSON hooks failures with EPIPE are now ignored, so if it fails with EPIPE for
other reasons than just exiting, I guess we might miss it
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1814543/+subscriptions
--
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help : https://help.launchpad.net/ListHelp
