Hello Christian, or anyone else affected, Accepted libseccomp into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libseccomp/2.3.1-2.1ubuntu4.1 in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: libseccomp (Ubuntu Bionic) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to libseccomp in Ubuntu. https://bugs.launchpad.net/bugs/1815415 Title: please update libseccomp for newer kernel syscalls Status in libseccomp package in Ubuntu: Fix Released Status in libseccomp source package in Bionic: Fix Committed Status in libseccomp source package in Cosmic: Fix Released Bug description: [Impact] * The libseccomp library provides an easy to use, platform independent, interface to the Linux Kernel's syscall filtering mechanism. But it can only "control" those syscalls it knows about. Therefore staying up to date with newer kernels is a requirement to be fully funcitonal. * At the time 18.04 was released with the 4.15 kernel the new definitions were not yet released for libseccomp - lets fix this mismatch by backporting the new syscall definitions [2][3][4]. [Test Case] * Note: a lot of this is kernel dependent it should work with the intended SRU target of Bionic with kernel 4.15 or 4.18, but be careful to run it there (e.g. not a LXD container on Xenials 4.4 kernel) * we modify the already existing autopkgtest for this SRU verification # Prep $ apt install ubuntu-dev-tools build-essential linux-libc-dev libseccomp-dev libseccomp2 seccomp $ pull-lp-source libseccomp bionic $ cd libseccomp-2.3.1 $ export ADTTMP=$(mktemp -d); echo $ADTTMP # run original tests as-is (should pass/fail as expected) $ ./debian/tests/test-filter # add new syscalls of this SRU $ cp debian/tests/data/safe.filter debian/tests/data/newcodes.filter $ printf "preadv2\npwritev2\npkey_mprotect\npkey_alloc\npkey_free\nget_tls\ns390_guarded_storage\ns390_sthyi\n" >> debian/tests/data/newcodes.filter # remove unknown calls (x86 4.18 kernel) sed -i -e '/^_exit$/d' -e '/^fstatvfs$/d' -e '/^llseek$/d' -e '/^pread$/d' -e '/^pselect$/d' -e '/^pwrite$/d' -e '/^sigtimedwait$/d' -e '/^sigwaitinfo$/d' -e '/^statvfs$/d' debian/tests/data/newcodes.filter # make unknown call a fail $ sed -i -e '111s/continue;/{fprintf(stderr, "failed to find %s\\n",buf);rc = -1;goto out;}/' debian/tests/src/test-seccomp.c # run this special test and check return value ${ADTTMP}/exe ./debian/tests/data/newcodes.filter /bin/date; echo $? Without the fix it will fail like: DEBUG: seccomp_load_filters ./debian/tests/data/newcodes.filter failed to find preadv2 seccomp_load_filters failed with -1 1 But with the fix applied those new calls will work: DEBUG: seccomp_load_filters ./debian/tests/data/newcodes.filter Tue Feb 12 07:41:05 UTC 2019 0 [Regression Potential] * This isn't adding new active code like functions, but only extending the definitions of per-arch syscall numbers to be aware of the newer syscalls that were added in the kernel. Therefore no old use-cases should regress (they are not touched). The only change in behavior for an SRU POV would be that things that got denied so far (e.g. if you tried to set such a new syscall through libseccomp) was denied before and would now work. I think that is exactly the intention of the SRU and not a regression. [Other Info] * Requested while security reviewing an libseccomp SRU to have one update for both [1]. * we also missed the former update for kernel 4.9 [3] AND 4.10 [4] as the official releases of the lib are rather seldom. * In general there already are build time tests and autopkgtests in the package already. So coverage of "old calls" for regressions is already good. --- This came up while working on bug 1755250 which asked for statx. But on the review of that it was pointed out [1] that it would be great to support further new kernel syscall defines - this isn't even looking at HWE kernels for Bionic, but "just" adding those which are there for the 4.15 kernel Bionic was released with. With the HWE kernels in mind there would be even more one might want to add, but there is no newer such update in the upstream repo yet. [1]: https://code.launchpad.net/~paelzer/ubuntu/+source/libseccomp/+git/libseccomp/+merge/362906/comments/944418 [2]: https://github.com/seccomp/libseccomp/commit/c842c2f6c203ad9da37ca60219172aa0be68d26a [3]: https://github.com/seccomp/libseccomp/commit/d9102f12fd39bd77151a1f630fcfc8c80f86c55c [4]: https://github.com/seccomp/libseccomp/commit/116b3c1a2e1db53cc35b74f30c080f5265faa674 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libseccomp/+bug/1815415/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
