Thanks for the patch. The approach broadly makes sense, three points for now:
* The documentation should be updated as well. * AFAICT _localize() is not handling the lang==NULL case correctly. * The calls to setlocale() are worrisome; we do use threads at least in the JavaScript runtime. It seems that gettext can work with per-thread locales (uselocale()), OTOH that might not be portable. (Honestly not sure about this. Colin?) (I haven’t reviewed the memory handling in detail -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to policykit-1 in Ubuntu. https://bugs.launchpad.net/bugs/619632 Title: Use gettext for translating user messages Status in PolicyKit: Unknown Status in Ubuntu Translations: Fix Released Status in policykit-1 package in Ubuntu: Fix Released Bug description: Binary package hint: policykit-1 PolicyKit currently requires translations to be in the XML, e.g.: <description>Install system color profiles</description> <description xml:lang="cs">Instalovat systémové profily barev</description> This makes it hard to modify translations after build-time and to provide only a set of translations (i.e. a language pack). It would be better to have: <description gettext-domain="gnome-color-manager">Install system color profiles</description> And use the standard gettext system. To manage notifications about this bug go to: https://bugs.launchpad.net/policykit-1/+bug/619632/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
