I forgot to mention one thing about the patch: the current behavior is that when on_ac_power returns 255 the current version of the script returns with that non zero error code and does not execute /usr/lib/apt/apt.systemd.daily. The patched version will execute /usr/lib/apt/apt.systemd.daily and terminate with whatever exit code that process generates.
On a side note, "which" can be replaced by "type" which is POSIX compatible and a shell built in. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to apt in Ubuntu. https://bugs.launchpad.net/bugs/1742378 Title: Slight glitch in /etc/cron.daily/apt-compat Ubuntu 16.04.3 in apt-1.2.24 Status in apt package in Ubuntu: Triaged Bug description: I accidentally stumbled across this. If in line 22 on_ac_power returns a non zero exit code the next line is never reached. Instead, the shell terminates immediately with that non zero exit code because of "set -e" in line 3. In this script it does not pose a problem because the shell is asked to exit anyway if check_power() returns non zero but it works differently than is apparently intended (concluding from the logic). I will attach a suggest patch and a demo illustrating that the patch works as the original script seems to intend to. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1742378/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
