Thanks Aron, the update seems mostly fine but some small comments

- usually SRUs changes are kept to the minimum, I guess you can argue
that the debian/rules change is safe and useful to you but unsure how
much the SRU team is going to like that (it's probably fine though but
we should at least try to describe the rational in the changelog)

- "  * Patches merged upstream and dropped:
    - manager-fix-state-transition-on-resuming-from-sleep.patch"

Why do you comment it in the serie and keep it in source rather than
cleaning it out?

- "  * Patches restored for which is relevant again:
    - Don-t-block-network.target-on-NetworkManager-wait-on.patch"

Could you give some more rational for this change, in what situation is
it useful? Ideally there would be a corresponding launchpad bug


The first points are nitpicks and shouldn't block the update but I think the 
restore patch need a bit more explanation, then looks fine to upload.


@Jeremy since you sponsored the previous version and were interested in some of 
the changes from Debian which are included do you maybe want to give the update 
a try to see if it address the issue you wanted to see fixed and then sponsor 
the changes?

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to network-manager in Ubuntu.
https://bugs.launchpad.net/bugs/1645698

Title:
  [SRU] Upgrade network-manager to latest point release

Status in network-manager package in Ubuntu:
  Fix Released
Status in network-manager source package in Xenial:
  Triaged
Status in network-manager source package in Yakkety:
  Fix Committed

Bug description:
  [Impact]

  This SRU would try to have the latest well-tested upstream point
  release (1.2.6) of 1.2.x land in Xenial, which is the successor of the
  current 1.2.2 version, fixing quite some bugs that's suitable to land
  in the stable branch.

  https://cgit.freedesktop.org/NetworkManager/NetworkManager/tree/NEWS?h=nm-1-2

  [Test Case]

  After installing the updated version, users should be able to avoid
  some mem leaks in some cases and have generally improved DNS related
  experiences.

  [Regression Potential]

  This is a bug/regression fix for 1.2.2 and 1.2.4, which is quite
  complete.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1645698/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to     : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to